fix: address Copilot review comments from PR #180#182
Merged
Conversation
- useToast: replace unsafe `as string` casts with typeof guards, skip __handled401 errors to prevent duplicate toasts - ReloadPrompt: clean up setInterval on unmount, add network/installing guards and try/catch per vite-plugin-pwa best practices - axios: replace never-resolving promise with marked rejection so .finally() cleanup blocks still run - vite proxy: only set Host:localhost header when using default Traefik target, skip when VITE_API_URL overrides it - annotation_dates: fetch job history once instead of 3x, sort by completed_at desc instead of submitted_at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as stringtype assertions withtypeofguards; silently skip__handled401errors to prevent duplicate toasts after 401 redirectonUnmounted; addnavigator.onLine/registration.installingguards and try/catch per vite-plugin-pwa best practicesnew Promise(() => {})with a markedPromise.reject()so.finally()cleanup blocks still runHost: localhostheader when using the default Traefik target; skip whenVITE_API_URLis setget_job_history(100)once instead of 3x per request; sort bycompleted_atdesc instead of relying onsubmitted_atorderTest plan
vue-tsc --noEmit)