My initial review on your code#3

Open

AliSoftware wants to merge 20 commits intomasterfrom

olivier/review-1

Commits on Apr 3, 2020

Adding missing assets
Olivier Halligon
committed
Removing warnings
Olivier Halligon
committed
Fix README
Olivier Halligon
committed
Fix Unit Test not compiling
Olivier Halligon
committed
I'm a nitpicker.
Olivier Halligon
committed
HSB colorspace makes it way easier to determine color brightness
Olivier Halligon
committed
CellStyle.defaultSize uses UIApplication.shared, not ideal. defaultSize is unused anyway…
Olivier Halligon
committed
Simplfying code for UIImageView+AsyncDownload and LoadAPIRequest
Olivier Halligon
committed
isFetchingresults -> isFetchingResults
Olivier Halligon
committed
Improved NetworkSession impl
Olivier Halligon
committed
Move declaration of Fonts constants to dedicated file
Olivier Halligon
committed
Extract APIKey to Global constants
Olivier Halligon
committed
Simplify APIRequest code
Olivier Halligon
committed
Improve ImageViewState structure
Olivier Halligon
committed
Using enum for static constants, and var -> let
Olivier Halligon
committed
Adding an indicator to UIImageView while loading
Olivier Halligon
committed
Review Notes so far
Olivier Halligon
committed

Commits on Apr 4, 2020

NetworkSession should be the one injecting the APIKey
Olivier Halligon
committed
Tests should not rely on queryParameters order
Olivier Halligon
committed
update ReviewNotes.md
Olivier Halligon
committed