This repository was archived by the owner on Apr 19, 2025. It is now read-only.
Swap order of bindings and event listeners#473
Open
shaun-wild wants to merge 1 commit intobestguy:masterfrom
Open
Swap order of bindings and event listeners#473shaun-wild wants to merge 1 commit intobestguy:masterfrom
shaun-wild wants to merge 1 commit intobestguy:masterfrom
Conversation
Author
|
Allowing different ordering is a feature of svelte but a bug for sveltestrap. See comment #461 (comment)
|
Author
|
I have created an issue on the official svelte repo, see sveltejs/svelte#7415. Hopefully there will be a nicer fix in future. |
(huh) that's why I said
as it is not a bug in Svelte. |
This was referenced Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR swaps the attributes for binds and events in the
InputandFormCheckcomponents.The Problem
As it turns out, the order of these attributes actually matters in the
input,selectetc components. If the event listener is listed before the bind, the bound value will not be up to date when the event listener is called.E.g.
and
function differently, in the first example,
yyywill not be the correct value in the event listener.The Solution
Considering there is currently no way to specify the order of attributes on sub-components, I think it makes more sense to use a sensible default.
Wasn't really sure how to test this without creating a test component. Please someone let me know if there is a better way to test this.