Update latlon #4349
Merged
Update latlon #4349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
VirtualFC shows NaN |
|
@Pancronos, please review. |
nerdCopter
approved these changes
Feb 18, 2025
|
Tested fine both virtual and real. Thank you!! needs translation :) |
KarateBrot
previously requested changes
Feb 20, 2025
|
McGiverGim
reviewed
Feb 21, 2025
Comment on lines
+2960
to
+2966
| "gpsLatitude": { | ||
| "message": "Latitude:", | ||
| "description": "Show GPS position - Latitude" | ||
| }, | ||
| "gpsLongitude": { | ||
| "message": "Longitude:", | ||
| "description": "Show GPS position - Longitude" |
There was a problem hiding this comment.
The Current is not needed anymore? I think remember it was "included" some time ago to differentiate with the Home Latitude / Longitude.
There was a problem hiding this comment.
It seems it was a not merged PR... #3486
KarateBrot
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the GPS data handling and display, specifically separating the latitude and longitude into distinct fields. The changes are made across multiple files to ensure consistency in the codebase.
Changes to GPS data handling and display:
locales/en/messages.json: Separated the GPS latitude and longitude messages into individual fields.src/js/fc.js: Updated theGPS_DATAobject to uselatitudeandlongitudeinstead oflatandlon.src/js/msp/MSPHelper.js: Modified theprocess_datafunction to readlatitudeandlongitudeinstead oflatandlon.src/js/tabs/gps.js: Updated theinitializefunction to handlelatitudeandlongitudeseparately, including changes to the UI updates and map centering logic. [1] [2] [3]src/js/tabs/setup.js: Adjusted theinitializefunction to update the display and URL generation forlatitudeandlongitudeseparately.src/tabs/gps.html: Split the GPS position display into separate rows for latitude and longitude.src/tabs/setup.html: Similarly, split the GPS position display into separate rows for latitude and longitude.