fix #123 - move res.send() outside streaming loop#124
Open
SUVAJIT-KARMAKAR wants to merge 2 commits intobetter-auth:mainfrom
Open
fix #123 - move res.send() outside streaming loop#124SUVAJIT-KARMAKAR wants to merge 2 commits intobetter-auth:mainfrom
SUVAJIT-KARMAKAR wants to merge 2 commits intobetter-auth:mainfrom
Conversation
SUVAJIT-KARMAKAR
changed the title
SUVAJIT-KARMAKAR
changed the title
Member
|
Hi @SUVAJIT-KARMAKAR, thanks for working on this! could you add a regression test case? |
Author
Sure, working on it @bytaesu |
Author
|
Hey @bytaesu, added the required test case for the fix. Kindly have a look. Thanks |
Author
|
Hi @bytaesu, any update on this fix ? |
Author
|
Hey, @bytaesu any direction ? |
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug in
setResponsewhereres.end()was incorrectly invoked inside theforloop within thenext()helper.This caused streamed responses to terminate prematurely after the first 16KB chunk.
Moves
res.end()outside the loop, ensuring the response is finalized only after all chunks are fully consumed from the reader.closes #123