Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions packages/better-call/src/adapters/node/request.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,41 @@ describe("getRequest", () => {
});

describe("setResponse", () => {
it("should write the full response body when it spans multiple chunks", async () => {
const socket = new Socket();
const req = new IncomingMessage(socket);
const res = new ServerResponse(req);

const chunks: Buffer[] = [];
let ended = false;

res.writeHead = vi.fn().mockReturnValue(res);
res.write = vi.fn().mockImplementation((chunk: Buffer) => {
chunks.push(Buffer.from(chunk));
return true;
});
res.end = vi.fn().mockImplementation(() => {
ended = true;
return res;
});

// Create a response body larger than 16KB to ensure multiple chunks
const largePayload = JSON.stringify({
data: "x".repeat(32 * 1024),
});

const webResponse = new Response(largePayload, {
status: 200,
headers: { "Content-Type": "application/json" },
});

await setResponse(res, webResponse);

const fullBody = Buffer.concat(chunks).toString();
expect(fullBody).toBe(largePayload);
expect(ended).toBe(true);
});

it("should set res.statusCode before writeHead for middleware compatibility", async () => {
// Regression test for https://github.com/better-auth/better-auth/issues/7035
// Some frameworks/middleware read res.statusCode before writeHead is called.
Expand Down
2 changes: 1 addition & 1 deletion packages/better-call/src/adapters/node/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ export async function setResponse(res: ServerResponse, response: Response) {
return;
}
}
res.end();
}
res.end();
} catch (error) {
cancel(error instanceof Error ? error : new Error(String(error)));
}
Expand Down