fix: return 400 for empty JSON body#130
Open
ping-maxwell wants to merge 1 commit intobetter-auth:mainfrom
Open
fix: return 400 for empty JSON body#130ping-maxwell wants to merge 1 commit intobetter-auth:mainfrom
ping-maxwell wants to merge 1 commit intobetter-auth:mainfrom
Conversation
The `getBody()` function calls `request.json()` unconditionally when the Content-Type header matches `application/json`:
```ts
if (jsonContentTypeRegex.test(normalizedContentType)) return await request.json();
```
When the body is empty or not valid JSON, request.json() throws a native SyntaxError. Since SyntaxError is not an instance of APIError, the router's catch block at router.mjs:84-99 falls through to the generic 500 handler:
console.error(`# SERVER_ERROR: `, error);
return new Response(null, { status: 500, statusText: "Internal Server Error" });
This affects all POST endpoints that don't define a body schema — because without body or disableBody: true, better-call still attempts JSON parsing.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes better-auth/better-auth#9295
The
getBody()function callsrequest.json()unconditionally when the Content-Type header matchesapplication/json:When the body is empty or not valid JSON,
request.json()throws a native SyntaxError. Since SyntaxError is not an instance of APIError, the router's catch block at router.mjs:84-99 falls through to the generic 500 handler:This affects all POST endpoints that don't define a body schema - because without body or disableBody: true, better-call still attempts JSON parsing.