Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/better-fetch/src/test/fetch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -566,19 +566,33 @@ describe("url", () => {
expect(url.toString()).toBe("http://localhost:4001/param/%23test/item%201");
});

it("should expand array values into multiple query parameters", () => {
it("should expand array values into multiple query parameters when repeatArrayParams is true", () => {
const url = getURL("/test", {
query: {
filterValue: ["admin", "user"],
},
baseURL: "http://localhost:4000",
repeatArrayParams: true,
});

expect(url.toString()).toBe(
"http://localhost:4000/test?filterValue=admin&filterValue=user",
);
});

it("should preserve arrays as JSON strings", () => {
const url = getURL("/test", {
query: {
filterValue: ["admin", "user"],
},
baseURL: "http://localhost:4000",
});

expect(url.toString()).toBe(
"http://localhost:4000/test?filterValue=%5B%22admin%22%2C%22user%22%5D",
);
});

it("should preserve objects as JSON strings", () => {
const url = getURL("/test", {
query: {
Expand Down
7 changes: 7 additions & 0 deletions packages/better-fetch/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ export type BetterFetchOption<
* Query parameters (key-value pairs)
*/
query?: Query;
/**
* When true, array query parameters are encoded as repeated keys
* (e.g. `?foo=a&foo=b&foo=c`) instead of JSON (`?foo=["a","b","c"]`).
*
* @default false - Arrays are encoded as JSON by default.
*/
repeatArrayParams?: boolean;
/**
* Dynamic parameters.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/better-fetch/src/url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function getURL(url: string, option?: BetterFetchOption) {
let serializedValue;
if (typeof value === "string") {
serializedValue = value;
} else if (Array.isArray(value)) {
} else if (option?.repeatArrayParams && Array.isArray(value)) {
for (const val of value) {
queryParams.append(key, val);
}
Expand Down