Fix: cloneResponse breaks onError hook#79
Open
leo91000 wants to merge 1 commit intobetter-auth:mainfrom
Open
Conversation
|
|
When cloneResponse option is enabled, clone the response before calling response.text() so the original response can still be cloned for hooks. Fixes better-auth#74
leo91000
force-pushed
the
fix/clone-response-error
branch
from
a17764e to
da00381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
When
hookOptions: { cloneResponse: true }is set, error responses now work correctly.Root cause:
response.text()was called beforeresponse.clone(), consuming the body.Fix: Clone before consuming in the error branch.