Draft
Conversation
|
@Gitstar-OC is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
ping-maxwell
requested changes
Mar 2, 2026
Member
ping-maxwell
left a comment
ping-maxwell
left a comment
There was a problem hiding this comment.
hey could you also fix merge conflicts too? Thanks
Member
There was a problem hiding this comment.
can you add .github-images to .gitignore please?
| @@ -1,5 +1,6 @@ | |||
| @import "tailwindcss"; | |||
| @import "tw-animate-css"; | |||
| @import "katex/dist/katex.min.css"; | |||
Member
There was a problem hiding this comment.
We need to find a way to only fetch the css for this when we actually render notebook.
You could consider importing it like:
// notebook-viewer.tsx
import "katex/dist/katex.min.css";
Member
There was a problem hiding this comment.
we've switched to bun, please remove this file.
Contributor
Author
|
sure! on it |
Gitstar-OC
force-pushed
the
feat/jupyter-notebook-support
branch
from
c1f93c7 to
f40f12c
Compare
Contributor
Author
|
ci is failing because of lockfile, fixing it! |
Contributor
Author
|
fixing this today : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #194, this PR adds support for rendering Jupyter Notebooks (
.ipynbfiles) directly in the repository file viewer. It includes a custom renderer that handles both markdown and code cells, with syntax highlighting and LaTeX math support (via KaTeX).New File
apps/web/src/components/repo/notebook-viewer.tsx: Main component for parsing and rendering notebook cells, including preprocessing for Jupyter-specific LaTeX quirks.Updated Files
apps/web/src/app/(app)/repos/[owner]/[repo]/blob/[...path]/page.tsx: IntegratedNotebookViewerinto the file viewer logic to detect.ipynbextensions.apps/web/src/components/repo/code-content-wrapper.tsx&repo-layout-wrapper.tsx: Adjusted layouts to support the notebook view.apps/web/src/app/globals.css: Added global styles for notebook cell containers and code blocks.apps/web/package.json: Added necessary dependencies for notebook rendering.apps/web/src/components/shared/client-markdown.tsx&highlighted-code-block.tsx: Minor updates to support notebook-specific rendering requirements.Images of how it looks are added in the issue!