Skip to content

fix: constrain actions filter dropdown height and prevent mobile overflow #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhiVarde wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

fix: constrain actions filter dropdown height and prevent mobile overflow #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion apps/web/src/components/actions/actions-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,13 +173,15 @@ function CombinedFilterDropdown({
}[];
}) {
const [open, setOpen] = useState(false);
const dropdownRef = useRef<HTMLButtonElement>(null);
const activeFilters = filters.filter((f) => f.options[0]?.value !== f.value);
const activeCount = activeFilters.length;

return (
<div className="relative">
<div className="flex items-center gap-1.5">
<button
ref={dropdownRef}
onClick={() => setOpen(!open)}
className={cn(
"flex items-center gap-1.5 px-2.5 py-1.5 text-[11px] font-mono border transition-colors cursor-pointer",
Expand Down Expand Up @@ -238,7 +240,21 @@ function CombinedFilterDropdown({
className="fixed inset-0 z-10"
onClick={() => setOpen(false)}
/>
<div className="absolute top-full left-0 mt-1 z-20 min-w-[260px] border border-border bg-background shadow-lg">
<div
className="fixed z-20 w-[calc(100vw-1rem)] max-w-65 max-h-[80vh] overflow-y-auto border border-border bg-background shadow-lg"
style={{
scrollbarWidth: "none",
msOverflowStyle: "none",
top:
(dropdownRef.current?.getBoundingClientRect()
.bottom ?? 0) + 4,
left: Math.min(
dropdownRef.current?.getBoundingClientRect()
.left ?? 0,
window.innerWidth - 260 - 8,
),
}}
>
{filters.map((filter, fi) => (
<div key={filter.label}>
{fi > 0 && (
Expand Down
Loading