Skip to content

fix: prevent editable base branch dropdown from being clipped #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ping-maxwell merged 2 commits into from
Apr 7, 2026
+16 −3
Merged

fix: prevent editable base branch dropdown from being clipped #340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09ced4
fix: prevent editable base branch dropdown from being clipped
AbhiVarde Apr 5, 2026
39cd00c
Merge branch 'main' into fix/editable-base-branch-dropdown-clipping
ping-maxwell Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions apps/web/src/components/pr/editable-base-branch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useState, useRef, useTransition, useEffect } from "react";
import { useState, useRef, useTransition } from "react";
import { useRouter } from "next/navigation";
import { GitBranch, ChevronDown, Check, Loader2, Search } from "lucide-react";
import { cn } from "@/lib/utils";
Expand Down Expand Up @@ -36,6 +36,7 @@ export function EditableBaseBranch({
const [search, setSearch] = useState("");
const [isPending, startTransition] = useTransition();
const dropdownRef = useRef<HTMLDivElement>(null);
const triggerRef = useRef<HTMLButtonElement>(null);
const searchRef = useRef<HTMLInputElement>(null);

useClickOutside(dropdownRef, () => setOpen(false));
Expand Down Expand Up @@ -80,6 +81,7 @@ export function EditableBaseBranch({
return (
<div className="relative inline-flex" ref={dropdownRef}>
<button
ref={triggerRef}
onClick={handleOpen}
disabled={!canEdit}
className={cn(
Expand All @@ -97,9 +99,20 @@ export function EditableBaseBranch({
<ChevronDown className="w-2.5 h-2.5 text-muted-foreground" />
)}
</button>

{open && (
<div className="absolute top-full left-0 mt-1.5 z-50 w-56 bg-background border border-border rounded-lg shadow-lg overflow-hidden">
<div
className="fixed z-50 w-56 bg-background border border-border rounded-lg shadow-lg overflow-hidden"
style={{
top:
(triggerRef.current?.getBoundingClientRect()
.bottom ?? 0) + 6,
left: Math.min(
triggerRef.current?.getBoundingClientRect()
.left ?? 0,
window.innerWidth - 224 - 8,
),
}}
>
<div className="px-2 py-1.5 border-b border-border/60">
<div className="flex items-center gap-1.5">
<Search className="w-3 h-3 text-muted-foreground shrink-0" />
Expand Down
Loading