Skip to content

fix: prevent PR review form dropdown from being clipped #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ping-maxwell merged 1 commit into from
Apr 7, 2026
+15 −1
Merged

fix: prevent PR review form dropdown from being clipped #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion apps/web/src/components/pr/pr-review-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export function PRReviewForm({ owner, repo, pullNumber, participants }: PRReview
const [isPending, startTransition] = useTransition();
const [error, setError] = useState<string | null>(null);
const panelRef = useRef<HTMLDivElement>(null);
const triggerRef = useRef<HTMLButtonElement>(null);

useClickOutside(
panelRef,
Expand Down Expand Up @@ -91,6 +92,7 @@ export function PRReviewForm({ owner, repo, pullNumber, participants }: PRReview
return (
<div ref={panelRef} className="relative">
<button
ref={triggerRef}
onClick={() => setOpen((o) => !o)}
className={cn(
"flex items-center gap-1.5 px-3 py-1.5 text-xs",
Expand All @@ -111,7 +113,19 @@ export function PRReviewForm({ owner, repo, pullNumber, participants }: PRReview
</button>

{open && (
<div className="absolute top-full right-0 mt-1.5 w-96 z-50 border border-border bg-background shadow-lg dark:shadow-2xl">
<div
className="fixed sm:w-96 z-50 border border-border bg-background shadow-lg dark:shadow-2xl"
style={{
top:
(triggerRef.current?.getBoundingClientRect()
.bottom ?? 0) + 6,
left: Math.max(
8,
(triggerRef.current?.getBoundingClientRect()
.right ?? 0) - 384,
),
}}
>
{/* Toolbar + Textarea */}
<div className="p-3 pb-2">
<MarkdownEditor
Expand Down
Loading