feat: add last verified date #17
Conversation
|
@amongus9000 is attempting to deploy a commit to the waffenffs' projects Team on Vercel. A member of the Team first needs to authorize it. |
Yes, we need a content notice / terms of service similar to the other bettergov projects as well as a way that points users where to contribute new or update stale hotlines but we can tackle that separately. Reviewed the PR and have a couple of suggestions. |
| "description": "Type of emergency hotline" | ||
| }, | ||
| "lastVerified": { | ||
| "type": "string", |
There was a problem hiding this comment.
Add a pattern here that enforces values follow the format YYYY-MM-DD.
| )} | ||
| {lastVerified && ( | ||
| <div className="text-gray-700 text-xs text-neutral"> | ||
| Last Verified: {new Date(lastVerified).toLocaleDateString()} |
There was a problem hiding this comment.
Format date as YYYY-MM-DD for consistency.
|
@smmariquit any updates on this? |
4 participants
This PR adds a last verified date field to the schema of the hotlines and fills that field all existing objects using the date in which each object was committed (sourced from the git blame)
I thought of the long-term feasibility of this project and realized that there's a glaring problem: data staleness. You'd need a really active set of maintainers, else you risk having wrong hotlines kasi nagbago na ng number or something.
One patch for that is to tie a last verified date to each hotline so at least we're saying na "we can only guarantee that this hotline is correct as of this date."
I've also added a vibe coded Python script to fill each lastUpdated field using the blame. I verified it for every single object and it seemed to be tama naman.