Rethink query / system access system to better account for Allows query filter #19086
Description
I don't think this use of "archetypal" access matches the original intent. (Although I don't know whether anyone is actually using it for its original purpose!)
From #11700,
It would be useful to be able to inspect a QueryState's accesses so we can detect when the data it accesses changes without having to iterate it.
Add the notion of "archetypal" accesses, which are not accessed directly, but whose presence in an archetype affects a query result.
Allows<T> is sort of the opposite, as it means T no longer affects the query result, even though it does by default on other queries.
I'd gently vote for making this a new kind of access. If we do want to use "archetypal" for this, then we should probably update the doc comment to say something other than "whose presence in an archetype may affect query results".
Originally posted by @chescock in #18192 (comment)