Merged
Conversation
Member
|
Huh, uxn failed to build lol. We should probably fixate the specific commit we are building on CI. (I'll do it) |
- Use the original uxn repo instead of uxn11 - Fixate the used commit - Build the uxncli directly bypassing the build.sh
Member
|
@yui-915 aight, looks good. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ref.btest was written before indexing became word-based, and didn't get updated afterwards.it worked on all of the current targets because they don't have very stricts memory bounds check, but fails on the javascript target I'm working on because it tries to access unallocated memory.