#474 Add properly scaled minHeight, maxHeight, to webflow sync by burnhamrobertp · Pull Request #568 · beyond-all-reason/maps-metadata

burnhamrobertp · 2026-02-04T15:43:23Z

These properties are already part of the metadata extracted and generated in the maps-cache metadata.json for each map. The values they have seem to use the same scale as mapWidth or mapHeight, and so are scaled accordingly before inclusion in the sync (value / 64)

…bflow sync These properties are already part of the metadata extracted and generated in the maps-cache metadata.json for each map

p2004a

Modifying WebsiteMapInfo is not sufficient, as comment says "internal representation of data used in this script". To sync out to webflow it is converted back and forth with WebflowMapInfo that builds from the webflow_types that you should be able to refresh with the read token you have.

burnhamrobertp · 2026-02-18T02:13:32Z

My utilization of makefiles has been pretty minimal since college. Running this repo in docker, with everything configured, with a .env file that has WEBFLOW_API_TOKEN and WEBFLOW_COLLECTION_ID I can echo $WEBFLOW_COLLECTION_ID or echo $WEBFLOW_API_TOKEN and get the expected value...however these values aren't present when running make refresh_webflow_types

What is the mechanism by which this is supposed to work, because I'm not seeing it.

Hrm, just setting EXPORT WEBFLOW_COLLECTION_ID=... seems to work; I wonder why the readme's setup isn't working though

p2004a · 2026-02-18T07:58:02Z

Have you sourced .env inside of container after you put export WEB... in it?

EDIT: forgot how it works, it is sourced automatically by container

maps-metadata/Dockerfile

Line 12 in baddc25

&& echo "source .envrc" >> $HOME/.bashrc

I will assume your env file looked like

VAR=asdasd

instead of

export BAR=asdasd

and that's why variables were not available in script

Or you didn't rebuild container.

EDIT2: probably makes sense to change code to not require export in .env file. That's likely expected by people.

burnhamrobertp · 2026-02-18T13:13:31Z

That's probably it, yes. I'm used to .env files that use VAR=asdf. Isn't export VAR=asdf bash-specific? I thought the whole point of using .env files like this is to keep it generic

p2004a · 2026-02-18T13:48:37Z

whole point of using .env files like this is to keep it generic

For me I always source them to have them as environment variables, so I always have export but that's just me, so I will fix that to make it more generic.

burnhamrobertp · 2026-02-18T14:17:09Z

If its a net reduction in the code quality to change it, I'm not opposed to using it as you've used it, but perhaps we add a .env.example that lays out the proper format

…le file

…nternal types

burnhamrobertp · 2026-02-19T22:14:33Z

Locally the web flow types are generating properly, although the dry run for syncing to web flow is missing the new property values, so I've missed something somewhere. Once I get the issue fixed, I'll have it pushed up

…/Max

burnhamrobertp · 2026-02-21T15:56:05Z

@p2004a this is ready for review when you have time

p2004a

As you upgrade to v3, we can also fix:

CollectionItemWithData is no longer needed, Webflow.CollectionItem defines fieldData again as non-optional.
fieldsToItem the TODO there was fixed, the as Webflow.CollectionItem can be removed.
Those id! are bad, but let's not fix it here, I've opened #590
Not for here, but also opened #591

p2004a · 2026-03-22T11:36:32Z

scripts/js/src/gen_webflow_types.ts

-                const values = field.validations.options.map((o: any) => o.name);
+            case Webflow.FieldType.File:
+            case Webflow.FieldType.ExtFileRef:
+                // File references are returned as URLs


I don't think they are: https://developers.webflow.com/data/reference/field-types-item-values#file

Where did you get it from?

p2004a · 2026-03-22T11:44:16Z

scripts/js/src/gen_webflow_types.ts

-            case 'Option': {
-                const values = field.validations.options.map((o: any) => o.name);
+            case Webflow.FieldType.File:
+            case Webflow.FieldType.ExtFileRef:


I cannot find any documentation for ExtFileRef as is the tradition with webflow api continuing to be undocumented mess. I would drop handling it then, and add handling only once we know what is the shape of data.

p2004a · 2026-03-22T11:56:35Z

scripts/js/src/gen_webflow_types.ts

+                propsWrite = { type: field.isRequired ? 'string' : ['string', 'null'], ...desc };
+                break;
+            case Webflow.FieldType.Option: {
+                const validations = field.validations as any;


eh, still bad... webflow/openapi-spec#3 (comment) (just comment, nothing to address here)

p2004a · 2026-03-22T12:06:23Z

scripts/js/src/sync_to_webflow.ts

    perspectiveShotUrl: string | null;
    moreImagesUrl: string[];
+    mapHeightMin: number;
+    mapHeightMax: number;


mapHeightMin must be handled also in:

isWebflowMapInfoEqual

WebflowMapInfo::constructor

WebflowMapInfo::generateFields

p2004a · 2026-03-22T12:15:59Z

scripts/js/src/sync_to_webflow.ts

            perspectiveShotUrl: (map.perspectiveShot.length > 0 ? `${imagorUrlBase}fit-in/2250x/filters:format(webp):quality(85)/${rowyBucket}/${encodeURI(map.perspectiveShot[0]!.ref)}` : null),
            moreImagesUrl: map.inGameShots.map(i => `${imagorUrlBase}fit-in/2250x/filters:format(webp):quality(85)/${rowyBucket}/${encodeURI(i.ref)}`),
            // Defaults from spring/cont/base/maphelper/maphelper/mapdefaults.lua
+            mapHeightMin: meta.minHeight,


You've put those properties in output of getDerivedInfo, let's read it from derivedInfo not meta.

p2004a · 2026-03-22T12:30:49Z

README.md

+cp .env.example .env
+```
+
+Populate the necessary values in .env


Maybe instead

For testing some scripts that push data to external services, setting env variables in .env might be also required

to make it clear it's not required for the most common cases.

beyond-all-reason#474 Add properly scaled minHeight, maxHeight, to we…

7d6203d

…bflow sync These properties are already part of the metadata extracted and generated in the maps-cache metadata.json for each map

p2004a requested changes Feb 15, 2026

View reviewed changes

burnhamrobertp added 2 commits February 19, 2026 15:29

beyond-all-reason#474 Add docker up alternative to readme, .env.examp…

2d37319

…le file

beyond-all-reason#474 Update webflow-api to latest version, utilize i…

b974725

…nternal types

beyond-all-reason#474 Update webflow_types, tie together mapHeightMin…

8f430bd

…/Max

p2004a requested changes Mar 22, 2026

View reviewed changes

Conversation

burnhamrobertp commented Feb 4, 2026

Uh oh!

p2004a left a comment

Choose a reason for hiding this comment

Uh oh!

burnhamrobertp commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p2004a commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

burnhamrobertp commented Feb 18, 2026

Uh oh!

p2004a commented Feb 18, 2026

Uh oh!

burnhamrobertp commented Feb 18, 2026

Uh oh!

burnhamrobertp commented Feb 19, 2026

Uh oh!

burnhamrobertp commented Feb 21, 2026

Uh oh!

p2004a left a comment

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

p2004a Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

burnhamrobertp commented Feb 18, 2026 •

edited

Loading

p2004a commented Feb 18, 2026 •

edited

Loading