tweak: RN-1773: trim value and label attributes of option relation
#6530
Conversation
| const uniqueOptionsCreated = new Map( | ||
| optionsCreated.map(option => [hashOption(option), option]), | ||
| ).values(); |
There was a problem hiding this comment.
JavaScript Set uses reference equality here, and we can’t provide a custom hash function; so we achieve the same effect with a Map
| const sortOrder = | ||
| existingOption?.sort_order ?? | ||
| ((await models.option.getLargestSortOrder(optionSetId)) ?? 0) + 1; |
There was a problem hiding this comment.
Nothing wrong with just using getLargestSortOrder every time; but this has the useless side effect of moving options from the middle of the sort order to the very end (and leaving a “gap”)
| await db.runSql(` | ||
| BEGIN; | ||
|
|
||
| -- Delete duplicates to ensure (option_set_id, TRIM(value)) is unique |
There was a problem hiding this comment.
Without this step, TRIM()-ing option.value will cause 16 conflicts (as of 20 October 2025)
packages/database/src/migrations/20251020010249-TrimAndDedupeOptions-modifies-data.js
Show resolved
Hide resolved
| ROW_NUMBER() OVER ( | ||
| PARTITION BY "option_set_id", TRIM("value") | ||
| ORDER BY "id" | ||
| ) > 1 AS "is_duplicate" |
There was a problem hiding this comment.
Keeps the option with the “lowest” id (presumably the oldest entry); but this is arbitrary
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jaskfla
force-pushed
the
rn-1773-option
branch
from
37247c3 to
584a575
Compare
jaskfla
force-pushed
the
rn-1773-option-1
branch
from
75472d7 to
57dddae
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jaskfla
force-pushed
the
rn-1773-option-1
branch
from
57dddae to
284006c
Compare
packages/central-server/src/apiV2/surveyResponses/upsertEntitiesAndOptions.js
Show resolved
Hide resolved
1 participant
RN-1773
Causes headaches with duplicate options in option sets.
Stack 🥞
This is PR 2 of 2 in a stack: