tweak: RN-1770: target Android API Level 35 (Android 15) #6555
Conversation
Summary of ChangesHello @jaskfla, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the application's target Android API level to 35. This change is crucial for maintaining compatibility with the latest Android operating system (Android 15), ensuring the application can utilize new platform features, and adhering to the most recent security and privacy standards mandated by Google Play. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to update the Android target API level to 35 (Android 15). While updating targetSdkVersion is a good step, the compileSdkVersion has not been updated in tandem. It's crucial to align compileSdkVersion with targetSdkVersion to ensure the app is built and tested against the new platform's APIs and behavioral changes. I've added a comment to address this oversight.
| minSdkVersion = 21 | ||
| compileSdkVersion = 34 | ||
| targetSdkVersion = 34 | ||
| targetSdkVersion = 35 |
There was a problem hiding this comment.
While updating targetSdkVersion to 35 is correct, the compileSdkVersion on line 7 should also be updated to 35. It is a best practice to keep compileSdkVersion and targetSdkVersion at the same value. This ensures your application is compiled against the APIs of the version it targets, allowing you to handle new platform behaviors and requirements correctly. Without this change, you might encounter unexpected runtime issues on Android 15 devices.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jaskfla
force-pushed
the
rn-1770-android-api-35
branch
from
61dc322 to
39bf35c
Compare
Applied all Android-related changes and some iOS-related changes
| * Returns the name of the main component registered from JavaScript. This is used to schedule | ||
| * rendering of the component. | ||
| */ | ||
| override fun getMainComponentName(): String = "MediTrak" |
There was a problem hiding this comment.
Bug: Android component name doesn't match JavaScript registration
getMainComponentName() returns "MediTrak" but the JavaScript code in main.jsx registers the app component as 'TupaiaMediTrak'. iOS (AppDelegate.swift) correctly uses "TupaiaMediTrak". This mismatch will cause the Android app to crash on startup because React Native won't find a component with the name "MediTrak".
| <key>UIRequiredDeviceCapabilities</key> | ||
| <array> | ||
| <string>armv7</string> | ||
| <string>armv64</string> |
There was a problem hiding this comment.
Bug: Invalid iOS device capability architecture value typo
The UIRequiredDeviceCapabilities key specifies armv64 which is not a valid iOS device capability. The correct value is arm64. This typo could cause App Store submission rejection or unexpected device compatibility issues.
1 participant
RN-1770