-
Notifications
You must be signed in to change notification settings - Fork 7
Document custom dashboard creation #6582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: edwin <edwin@bes.au>
|
Cursor Agent can help with this pull request. Just |
Summary of ChangesHello @edmofro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive end-user guide for creating custom dashboard items within Tupaia's Admin Panel. The new documentation, located at Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new user guide for creating custom dashboards in the Admin Panel. The guide is well-structured and provides clear, step-by-step instructions. My review focuses on ensuring the terminology used in the guide perfectly matches the UI elements in the application for an optimal end-user experience. I've suggested a few minor text changes to align the documentation with the field labels found in the code.
| - If you do not see the Visualisation Builder links, ask someone with BES Admin rights to grant you Viz Builder access. This cannot be done through the public site. | ||
|
|
||
| ## 2. Open the Visualisation Builder | ||
| - Go to **Visualisations → Dashboard items** and choose **Add dashboard item** (or open an existing item and click **View in Visualisation Builder**). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions clicking View in Visualisation Builder to open an existing item. Based on the code in packages/admin-panel/src/routes/visualisations/dashboardItems.jsx, the link text for editing an existing item from the list is Edit using Visualisation Builder. To ensure consistency with the UI, it's best to update the text in the guide.
| - Go to **Visualisations → Dashboard items** and choose **Add dashboard item** (or open an existing item and click **View in Visualisation Builder**). | |
| - Go to **Visualisations → Dashboard items** and choose **Add dashboard item** (or open an existing item and click **Edit using Visualisation Builder**). |
| - The download icon exports the current visualisation as a JSON file so you can keep a backup or share it with teammates. | ||
|
|
||
| ## 7. Place the item on a dashboard | ||
| - Saving a visualisation does not automatically show it to end users. Back in **Visualisations → Dashboard relations**, create a relation that links your new dashboard item to a dashboard code, the entity types (e.g. country, facility), the permission groups, the target projects, and an optional sort order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation refers to "the target projects" when creating a dashboard relation. In the UI, this field is labeled "Project codes" (as seen in packages/admin-panel/src/routes/visualisations/dashboardRelations.js). To avoid confusion for the user, it's best to use the exact terminology from the application interface.
| - Saving a visualisation does not automatically show it to end users. Back in **Visualisations → Dashboard relations**, create a relation that links your new dashboard item to a dashboard code, the entity types (e.g. country, facility), the permission groups, the target projects, and an optional sort order. | |
| - Saving a visualisation does not automatically show it to end users. Back in **Visualisations → Dashboard relations**, create a relation that links your new dashboard item to a dashboard code, the entity types (e.g. country, facility), the permission groups, the project codes, and an optional sort order. |
|
|
||
| ## 7. Place the item on a dashboard | ||
| - Saving a visualisation does not automatically show it to end users. Back in **Visualisations → Dashboard relations**, create a relation that links your new dashboard item to a dashboard code, the entity types (e.g. country, facility), the permission groups, the target projects, and an optional sort order. | ||
| - If you also need a brand new dashboard tab, add it under **Visualisations → Dashboards** before creating the relation. Set the dashboard’s code, name, and root entity (the top-level location that owns the dashboard). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions setting the "root entity" for a new dashboard. The corresponding field in the UI is labeled "Organisation unit code" (as defined in packages/admin-panel/src/routes/visualisations/dashboards.js). Using the UI label will make the guide clearer for end-users.
| - If you also need a brand new dashboard tab, add it under **Visualisations → Dashboards** before creating the relation. Set the dashboard’s code, name, and root entity (the top-level location that owns the dashboard). | |
| - If you also need a brand new dashboard tab, add it under **Visualisations → Dashboards** before creating the relation. Set the dashboard’s code, name, and organisation unit code (the top-level location that owns the dashboard). |
Issue #: N/A
Changes:
packages/admin-panel/doc/customDashboardGuide.md) detailing how to create custom dashboard items in Tupaia's Admin Panel using the Visualisation Builder.Screenshots:
N/A