Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ t/ack-s.yaml
t/ack-show-types.t
t/ack-type-del.t
t/ack-type.t
t/ack-type.yaml
t/ack-v.yaml
t/ack-version.t
t/ack-w.t
Expand Down
8 changes: 6 additions & 2 deletions lib/App/Ack/ConfigLoader.pm
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ sub _uninvert_filter {
for ( my $i = 0; $i < @{ $opt->{filters} }; $i++ ) {
my $opt_filter = @{ $opt->{filters} }[$i];

# XXX Do a real list comparison? This just checks string equivalence.
if ( $opt_filter->is_inverted() && "$opt_filter->{filter}" eq "@filters" ) {
if ( $opt_filter->is_inverted()
&& grep { $_ == $opt_filter->{filter} } @filters )
{
splice @{ $opt->{filters} }, $i, 1;
$i--;
}
Expand Down Expand Up @@ -176,6 +177,9 @@ sub _process_filetypes {
if ( not $value ) {
@filters = map { $_->invert() } @filters;
}
else {
_uninvert_filter( $opt, @filters );
}

push @{ $opt->{'filters'} }, @filters;
};
Expand Down
44 changes: 44 additions & 0 deletions t/ack-type.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
---
name: --type-set and exclude
args: >-
--ignore-ack-defaults
--type-set=cmake:is:CMakeLists.txt
--type=nocmake
-k -f t/swamp
exitcode: 1
stderr: ''
stdout: ''

---
name: --type-set and override exclusion
args: >-
--ignore-ack-defaults
--type-set=cmake:is:CMakeLists.txt
--type=nocmake
-t cmake -f t/swamp
stdout: |
t/swamp/CMakeLists.txt

---
name: --type-set, --type-add, and exclude
args: >-
--ignore-ack-defaults
--type-set=cmake:is:CMakeLists.txt
--type-add=cmake:ext:cmake
--type=nocmake
-k -f t/swamp
exitcode: 1
stderr: ''
stdout: ''

---
name: --type-set, --type-add, and override exclusion
args: >-
--ignore-ack-defaults
--type-set=cmake:is:CMakeLists.txt
--type-add=cmake:ext:cmake
--type=nocmake
-t cmake -f t/swamp
stdout: |
t/swamp/CMakeLists.txt
t/swamp/stuff.cmake
2 changes: 1 addition & 1 deletion t/yaml.t
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use warnings;
use strict;

use Test::More tests => 26;
use Test::More tests => 27;

use lib 't';
use Util;
Expand Down