Skip to content

[rfc]: added proxy support via proxy-agent#20

Open
c33s wants to merge 2 commits intobeyonk:masterfrom
c33s:feature/proxy-support
Open

[rfc]: added proxy support via proxy-agent#20
c33s wants to merge 2 commits intobeyonk:masterfrom
c33s:feature/proxy-support

Conversation

@c33s
Copy link
Copy Markdown

@c33s c33s commented Jul 2, 2021

sadly node has not added proxy support to its core yet (nodejs/node#15620) so it is necessary to implement it in each client lib -.-

i added proxy support to via https://github.com/TooTallNate/node-proxy-agent to your awesome lib.

i haven't added tests yes and i am not sure about correctly updating the package-lock.json (had not worked on a node module before). is it just a npm install required to generate the correct lock file or is there something special for a node module?

also i am not quite happy with the mixed type variable (boolean/object), i thought about empty object, object and undefined

references:

edit: not really an idea how to test this.

edit2: as proxyagent should work transparent, maybe using it could be the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant