Fix race condition in asset loader when script tag hasn't loaded#102
Open
ndri wants to merge 1 commit intobeyonk:masterfrom
Open
Fix race condition in asset loader when script tag hasn't loaded#102ndri wants to merge 1 commit intobeyonk:masterfrom
ndri wants to merge 1 commit intobeyonk:masterfrom
Conversation
When multiple components mount simultaneously, the script tag may already exist in the DOM but mapboxgl hasn't finished loading yet. The loader would call cb() immediately, causing TypeError when trying to set accessToken on undefined. Now checks if window.mapboxgl is available. If not, waits for the existing script's load event before calling the callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple components mount simultaneously, the script tag may already exist in the DOM but mapboxgl hasn't finished loading yet. The loader would call cb() immediately, causing TypeError when trying to set accessToken on undefined.
Now checks if window.mapboxgl is available. If not, waits for the existing script's load event before calling the callback.