-
Notifications
You must be signed in to change notification settings - Fork 14
Minor update #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Minor update #105
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8d33657
Merge pull request #102 from bigbio/dev
ypriverol d91c7a8
fix bugs in features2peptides
yueqixuan 00b42d4
fix bugs in features2peptides
yueqixuan 04adcbd
update README
yueqixuan dcd7fe8
Merge pull request #1 from yueqixuan/dev
yueqixuan a2d3829
update README
yueqixuan 48ad75c
Merge pull request #2 from yueqixuan/dev
yueqixuan b7fe899
Add filtering for files not in SDRF
yueqixuan e8ffd68
Merge pull request #3 from yueqixuan/dev
yueqixuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,7 +66,9 @@ def classify( | |
| """ | ||
| label_scheme = None | ||
|
|
||
| if len(labels) == 1 and any("label free" in s.lower() for s in labels): | ||
| if len(labels) == 1 and any( | ||
| keyword in s.lower() for s in labels for keyword in ["lfq", "label free"] | ||
| ): | ||
|
Comment on lines
+69
to
+71
|
||
| label_category = cls.LFQ | ||
|
|
||
| elif any("tmt" in s.lower() for s in labels): | ||
|
|
@@ -96,7 +98,7 @@ def classify( | |
|
|
||
| else: | ||
| raise ValueError( | ||
| f"Cannot infer labeling scheme from {labels}, only support label free, TMT and ITRAQ experiment!" | ||
| f"Cannot infer labeling scheme from {labels}, only support label free (or lfq), TMT and ITRAQ experiment!" | ||
| ) | ||
| return label_category, label_scheme | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command uses 'ibaqpyc' instead of 'ibaqpy'. This appears to be a typo in the documentation.