graphql-server: Add readOnlyId prop to sharedNotes#18658
Closed
gustavotrott wants to merge 1 commit intobigbluebutton:v3.0.x-releasefrom
Closed
graphql-server: Add readOnlyId prop to sharedNotes#18658gustavotrott wants to merge 1 commit intobigbluebutton:v3.0.x-releasefrom
gustavotrott wants to merge 1 commit intobigbluebutton:v3.0.x-releasefrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BBB used to employ Etherpad's read-only view for users who didn't have writing privileges. This functionality was modified by #13916.
After some tests, I found that
bbb-padsautomatically invalidates a user's session once they lose writing rights. As a result, even if the user tries to restore their previous session, they will no longer have the ability to modify the note.For the upcoming BBB 2.8 release, I plan to conduct tests utilizing Etherpad's read-only mode. This is because the read-only mode offers a significantly improved user experience.
This particular PR handle the
PadCreatedEvtMsgmessage which will begin to bringreadOnlyID, store it in the database and provide through Graphql.Depends on: bigbluebutton/bbb-pads#34 (and then tweak https://github.com/bigbluebutton/bigbluebutton/blob/develop/bbb-pads.placeholder.sh)