Skip to content

Conversation

@s5bug
Copy link

@s5bug s5bug commented Jun 2, 2022

TODO:

  • Make CelesteNet an optional dependency
  • Remove players from the set of un-refreshed Ghosts when they disconnect
  • Figure out why the Change message isn't sent to new players
  • Fix hair and death animation for other players

s5bug added 3 commits June 1, 2022 19:24
_Why_ is Add not an upsert by default? Why do I have to use the syntax sugar?
- Name: Everest
Version: 1.2742.0
Version: 1.2742.0
- Name: CelesteNet.Client
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely think CN should be an optional dependency, so this will need some logic to only run the CN logic if the dependency is loaded

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I gotta add some more checkboxes to the first post

@s5bug
Copy link
Author

s5bug commented Jun 3, 2022

@bigkahuna443 Going through the after-Badeline-orb-cutscene (where Madeline splits into both Madeline and Badeline and they have dialogue) crashes. I know why it happens, it's something to do with animation frames, but I don't exactly know where to fix it.

@bigkahuna443
Copy link
Owner

@s5bug Can't replicate it with the Niko skin mod, what are you using? If it's something specific with your changes I'd need more details. Also if you want to reach me, it'd be better to ping/DM me on Discord, I don't check my GH notifications lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants