Skip to content

Fix 11261 floating point overflow in calc effective shr #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevin-moos wants to merge 555 commits into from
Closed

Fix 11261 floating point overflow in calc effective shr #6

kevin-moos wants to merge 555 commits into from

Conversation

@kevin-moos
Copy link

@kevin-moos kevin-moos commented Oct 8, 2025

Pull request overview

  • Fixes #ISSUENUMBERHERE

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

rraustad and others added 30 commits August 6, 2025 13:54
@rraustad
Clean up a few issues
f93217e
@rraustad
Add output rules for new and revised tables
aeb734f
@rraustad
Add a section in Eng. Ref. and adjust code/inputs accordingly.
bd36f68
@JasonGlazer
Populate the WaterUse Connection Name column.
00411b3
@JasonGlazer
Change to methods to populate tables.
949f3cb
@JasonGlazer
Remove old code and update NFP notes.
eda7580
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into 10919Missi…
4d90634 
…ngInfoExtFenestrationShadeTable
change generator version for windows-2022 build
2057a2b
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into 10919Missi…
d75c73d 
…ngInfoExtFenestrationShadeTable
@mjwitte
Fix shaded glass shgc 11149
74eff01
revise documentation, update calc in op mode EMS and schedule
05ca67c
Merge remote-tracking branch 'origin/NewAWHPobject' into NewAWHPobject
784ee4a
update IO reference doc, correct output var units
972778e
@JasonGlazer
Merge branch 'develop' into Ruleset-createRPD-Ph4
1aa8fcb
@RKStrand
Addition of reporting info to EIO
acde502 
The information that was added to the HTML tabular report was not reporting to the EIO like it does for windows with frames/dividers.  This corrects this issue and now reports to the EIO.
@JasonGlazer
Add AirLoopHVAC:OutdoorAirSystem Name column to System Summary-Econom…
f3ad7e3 
…izer table [decent_ci_skip] [actions skip]
add air temp, flow rate, curve value output; update doc
a6c9c3e
minor mod in idd: 0 to 0.0
9202c44
clang-format
e29ccd6
@JasonGlazer
NFP fixes on control related reports
39f2e91
@JasonGlazer
Add new ControlSummary - SetpointManager:OutdoorAirReset table
46674bc
@JasonGlazer
Add Control Summary SetpointManager:ReturnTemperature table
33d1bb2
@JasonGlazer
Update OutputChanges25-1-0-to-25-2-0.md
c431c21
@mjwitte
Avoid duplication in shaded fenestration reports
b6b72ee
testfile remove unused object, correct actuator comp ctrl type
eb5827b
@JasonGlazer
Fix SQL unit tests that expect specific report name numbers
70a7049
@JasonGlazer
Fix clang format issues.
c552d23
@JasonGlazer
Merge branch 'develop' into Ruleset-createRPD-Ph4
0625d90
add input min max leaving water temp curve name
54e7cb5
add min max water temp limit curve input
5a6f20a
mitchute and others added 29 commits October 1, 2025 10:59
@mitchute
Merge pull request NREL#11237 from NREL/11181_Sunlit_Fractions_shading
900b047 
Fix NREL#11181 - Wrong Sunlit fractions for Detached Shading Surfaces when Sun is Down
@kevin-moos
Added comments to OutputChanges25-1-0-to-25-2-0.md for new columns in…
cd65b63 
… Predefined Monthly Summary Reports
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into 10896Table…
81501cf 
…Rounding
@mjwitte
Implement format options for economics
ba6b96b
@mitchute
Merge pull request NREL#11001 from NREL/NewAWHPobject
d4b5202 
A new air to water heat pump object
@mjwitte
format
e3d5266
@mjwitte
unit test cleanup
c1438fb
@mitchute
Merge branch 'develop' into 11214-ExcessiveWarnings
c2c1fdb
@jmarrec
clang format bctvb before changing it
8d0e1c0
@jmarrec
Modernize utilXml's check_variable_cfg_Validate
b88629b
@jmarrec
Modernize utilSocke tassembleBuffer from sprintf to snprintf
233a827
@jmarrec
Ignore deprecated declarations for penumbra's glfw (sprintf)
3405fb1
@mitchute
Merge pull request NREL#11231 from NREL/11214-ExcessiveWarnings
a4c9dbe 
AirloopHVAC:UnitarySystem with variable speed coil reports Coil control failed
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into 10896Table…
d56493d 
…Rounding
@mjwitte
Fix missing reference from AFN Duct Model PR
ec4e901
@mjwitte
Fix duplicate SQLite tables
5979ad8
@mjwitte
Revised example file
3ddb135
@mjwitte
Fix economic tariff variable reporting if multiple table passes
ebf2a47
@mjwitte
Fix component sizing reporting if multiple table passes
bcbe5cd
@mjwitte
Minor cleanup
8f31c74
@jmarrec
NREL#11244 - Add a PVWatts tests with tilt = 0 which triggers the nan…
753bd7e 
… thing

When DEBUG_ARITHM_GCC_OR_CLANG is on, on arm64 mac:
```
[ RUN      ] EnergyPlusFixture.PVWatts_SSC_NaNFailure
Illegal instruction: 4     ./Products/energyplus_tests -- --gtest_filter=*PVWatts_SSC_NaNFailure*
```

When DEBUG_ARITHM_GCC_OR_CLANG is not on, on arm64 mac it passes
@jmarrec
Fix NREL#11244 - Avoid nan computations in `sssky_diffuse_table::comp…
e00188c 
…ute`

on arm64 mac:
atan works with a quiet_NaN
tan throws a FE_INVALID floating point exception in https://developer.arm.com/documentation/dui0801/g/A64-Floating-point-Instructions/FCVTNS--scalar-

```
    double nan = std::numeric_limits<double>::quiet_NaN();
    double atan_nan = std::atan(nan);
    EXPECT_TRUE(std::isnan(atan_nan));
    double tan_nan = std::tan(nan);
    EXPECT_TRUE(std::isnan(tan_nan));
```
@mitchute
turn off stale pr notifications for now
2938e6d
@mitchute
Merge pull request NREL#11257 from NREL/no-notify-stale-prs
dbe14be 
Turn Off Stale PR Notifications for Now
@mitchute
Merge pull request NREL#11253 from NREL/11245_LEEDSummary_RenewableEn…
d5e5c63 
…ergySourceSummary

Fix NREL#11245 LEEDSummary_RenewableEnergySourceSummary Unit Test Fails on Mac Debug
@mitchute
Merge pull request NREL#11246 from NREL/11244_clang17
f6ff83e 
Fix NREL#11244 - Allow building with AppleClang 17
@mitchute
Merge pull request NREL#11210 from NREL/10896TableRounding
86cc706 
New formatting and units options for table outputs (Tabular, SQLite, and JSON)
@mitchute
Merge pull request NREL#11209 from bigladder/Fix-11205-Refrigeration-…
05a6784 
…missing-from-monthly-end-use-reports

Fix 11205 refrigeration missing from monthly end use reports
@kevin-moos
Prevent floating-point overflow in CalcEffectiveSHR
99ab42e
@kevin-moos kevin-moos closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.