Add new new metric: Comet#52
Draft
cjlovering wants to merge 4 commits intomasterfrom
Draft
Conversation
* Added dependency * Added wiring for using it by default in a translation task * (We should discuss the above -- i.e. is it desired?) * Uses the same framework as SARI -- exepcts a `doc_to_rawtext` to be implemented
Closed
Collaborator
|
@rbawden, do you think we should use this as the default? |
|
I'm not really sure. BLEU is still the most used metric by far I'd say, so we should include results for it and it might be wise to keep it as default (despite all the criticisms). I would tentatively say COMET could be a secondary metric, but it could be worth checking with some other people to see what the consensus is. |
Collaborator
Author
|
Update: I think that computing COMET after the pipeline has been run would be cleaner. I will return to this in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc_to_rawtextto beimplemented
TODOs