Skip to content

Bug fix failed users fetchon first run #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuarkNerd wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug fix failed users fetchon first run #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7a0153
Call load user functions on sign in
QuarkNerd Sep 5, 2018
cbf0cd7
Props validation
QuarkNerd Sep 5, 2018
9530000
Merge branch 'master' into BUG_FIX-faled-users-fetch
tclarke-scottlogic Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/App/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,11 @@ class App extends Component {
}
],
callbacks: {
signInSuccessWithAuthResult: res =>
this.setState({loggedIn: res.user !== null})
signInSuccessWithAuthResult: res => {
this.setState({loggedIn: res.user !== null});
this.props.loadUsers();
this.props.loadSlackUserReference();
}
}
};

Expand Down Expand Up @@ -153,7 +156,9 @@ class App extends Component {
}

App.propTypes = {
setDataController: PropTypes.func.isRequired
setDataController: PropTypes.func.isRequired,
loadUsers: PropTypes.func.isRequired,
loadSlackUserReference: PropTypes.func.isRequired
};

export default App;
5 changes: 4 additions & 1 deletion src/components/App/AppContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import App from './App';
import {connect} from 'react-redux';
import {setDataController} from './actions';
import {loadUsers, loadSlackUserReference} from '../Home/actions';

const mapDispatchToProps = {
setDataController
setDataController,
loadSlackUserReference,
loadUsers
};

export default connect(
Expand Down