This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Closed
Conversation
I make an update of the index.astro file from my remote repository on manual instead of using the IDE I've.
…orito/Hacktion into Create_aboutus_section
Member
|
No olvides seguir conventional commits para nombrar las PRs |
Member
|
Junto a eso, no olvides hacer formateo de tu codigo con el uso de |
Member
|
Favor de respetar la template al crear una PR. Esto resuelve issue #49 |
Member
|
Generaste un |
Contributor
Author
|
Ok, los checo lo más rápido posible. -Kai |
Contributor
Author
|
Según yo ya quedo, ya hice el dmt y volví a hacer push. -Kai |
EGAMAGZ
suggested changes
Jun 11, 2025
Member
EGAMAGZ
left a comment
EGAMAGZ
left a comment
There was a problem hiding this comment.
Al desarrollar las secciones asignadas, procura que se parezcan a la maqueta original
Considera el uso de los componentes de neobrutalism, los cuales ya se encuentran en src/components/ui/
Comment on lines
+7
to
+24
| <header class="w-full px-6 py-4 flex justify-between items-center border-b border-gray-300"> | ||
| <div class="text-lg font-semibold"> | ||
| <img src="/notion-logo.svg" alt="Notion logo" class="w-6 inline-block mr-2" /> | ||
| Notion Campus Leaders | ||
| </div> | ||
| <nav class="flex space-x-6 text-sm font-medium"> | ||
| <a href="#acerca" class="hover:underline">Acerca de nosotros</a> | ||
| <a href="#retos" class="hover:underline">Retos</a> | ||
| <a href="#sede" class="hover:underline">Sede</a> | ||
| <a href="#highlights" class="hover:underline">Highlights</a> | ||
| <a | ||
| href="#sponsor" | ||
| class="bg-transparent border border-green-600 px-3 py-1 rounded hover:bg-green-100" | ||
| >Se sponsor</a> | ||
| <a href="#registro" class="bg-green-600 text-white px-3 py-1 rounded hover:bg-green-700" | ||
| >Regístrate</a> | ||
| </nav> | ||
| </header> |
Member
There was a problem hiding this comment.
Suggested change
| <header class="w-full px-6 py-4 flex justify-between items-center border-b border-gray-300"> | |
| <div class="text-lg font-semibold"> | |
| <img src="/notion-logo.svg" alt="Notion logo" class="w-6 inline-block mr-2" /> | |
| Notion Campus Leaders | |
| </div> | |
| <nav class="flex space-x-6 text-sm font-medium"> | |
| <a href="#acerca" class="hover:underline">Acerca de nosotros</a> | |
| <a href="#retos" class="hover:underline">Retos</a> | |
| <a href="#sede" class="hover:underline">Sede</a> | |
| <a href="#highlights" class="hover:underline">Highlights</a> | |
| <a | |
| href="#sponsor" | |
| class="bg-transparent border border-green-600 px-3 py-1 rounded hover:bg-green-100" | |
| >Se sponsor</a> | |
| <a href="#registro" class="bg-green-600 text-white px-3 py-1 rounded hover:bg-green-700" | |
| >Regístrate</a> | |
| </nav> | |
| </header> |
La etiqueta header en este contexto no se debería usar. Seria solo nav. En este caso @AaronVanScoit estaria trabajando en la barra de navegacion en el issue #44. No esta mal el querer aprovechar y solventarlo pero junto a eso, no se parece conforme a la maqueta
Comment on lines
+27
to
+42
| <section class="text-center py-16 px-4"> | ||
| <h2 class="text-sm text-gray-600">Notion Campus Leaders</h2> | ||
| <h1 class="text-5xl font-bold mt-2">Hacktion</h1> | ||
| <p class="mt-2 text-lg text-gray-700">Construyamos el futuro juntos 🚀</p> | ||
| <div class="mt-6 space-x-4"> | ||
| <a | ||
| href="#acerca" | ||
| class="bg-white border border-green-600 text-green-600 px-4 py-2 rounded hover:bg-green-50" | ||
| > | ||
| Conócenos | ||
| </a> | ||
| <a href="#registro" class="bg-green-600 text-white px-4 py-2 rounded hover:bg-green-700"> | ||
| Regístrate | ||
| </a> | ||
| </div> | ||
| </section> |
Member
There was a problem hiding this comment.
Suggested change
| <section class="text-center py-16 px-4"> | |
| <h2 class="text-sm text-gray-600">Notion Campus Leaders</h2> | |
| <h1 class="text-5xl font-bold mt-2">Hacktion</h1> | |
| <p class="mt-2 text-lg text-gray-700">Construyamos el futuro juntos 🚀</p> | |
| <div class="mt-6 space-x-4"> | |
| <a | |
| href="#acerca" | |
| class="bg-white border border-green-600 text-green-600 px-4 py-2 rounded hover:bg-green-50" | |
| > | |
| Conócenos | |
| </a> | |
| <a href="#registro" class="bg-green-600 text-white px-4 py-2 rounded hover:bg-green-700"> | |
| Regístrate | |
| </a> | |
| </div> | |
| </section> | |
| <section class="text-center py-16 px-4"> | |
| <span class="text-sm text-gray-600">Notion Campus Leaders</span> | |
| <h2 class="text-5xl font-bold mt-2">Hacktion</h2> | |
| <span class="mt-2 text-lg text-gray-700">Construyamos el futuro juntos 🚀</span> | |
| <div class="mt-6 space-x-4"> | |
| <a | |
| href="#acerca" | |
| class="bg-white border border-green-600 text-green-600 px-4 py-2 rounded hover:bg-green-50" | |
| > | |
| Conócenos | |
| </a> | |
| <a href="#registro" class="bg-green-600 text-white px-4 py-2 rounded hover:bg-green-700"> | |
| Regístrate | |
| </a> | |
| </div> | |
| </section> |
En si el contenido no esta mal, pero esta lejano al contenido original en esperado:
El html semantico no esta mal, pero no son las etiquetas adecuadas. Hice anotaciones de unas etiquetas que podrian ser mas ad hoc
Comment on lines
+45
to
+75
| <section | ||
| id="acerca" | ||
| class="max-w-4xl mx-auto py-16 px-4 flex flex-col md:flex-row items-center gap-8" | ||
| > | ||
| <div class="flex-1"> | ||
| <h2 class="text-3xl font-bold mb-4">Acerca de nosotros</h2> | ||
| <p class="mb-2"> | ||
| Hacktion es un hackathon hecho por la comunidad de Notion Campus Leaders en colaboración | ||
| con muchas otras comunidades de desarrollo. | ||
| </p> | ||
| <p> | ||
| Busca crear un espacio donde personas que van adentrándose a la informática puedan | ||
| experimentar su primer hackathon, aprender y conectar con otros entusiastas de la | ||
| tecnología. | ||
| </p> | ||
| </div> | ||
| <img | ||
| src="/tu-imagen.jpg" | ||
| alt="Foto de la comunidad" | ||
| class="rounded-lg shadow-lg w-full md:w-96" | ||
| /> | ||
| </section> | ||
|
|
||
| <!-- Retos --> | ||
| <section id="retos" class="max-w-4xl mx-auto py-16 px-4"> | ||
| <h2 class="text-3xl font-bold mb-4">Retos</h2> | ||
| <p> | ||
| Aquí puedes describir los retos principales del hackathon, categorías, tecnologías | ||
| sugeridas, etc. | ||
| </p> | ||
| </section> |
Member
There was a problem hiding this comment.
Igual, no esta mal el aprovechar y solventar más issues, en este caso el #47. Ya @mendodevv se encuentra solucionando.
Por esta parte igual, no se parece a la referencia
Comment on lines
+102
to
+108
| <!-- Registro --> | ||
| <section id="registro" class="max-w-4xl mx-auto py-16 px-4"> | ||
| <h2 class="text-3xl font-bold mb-4">Regístrate</h2> | ||
| <p> | ||
| Aquí puedes poner el formulario de registro o un enlace a un formulario externo. | ||
| </p> | ||
| </section> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- Registro --> | |
| <section id="registro" class="max-w-4xl mx-auto py-16 px-4"> | |
| <h2 class="text-3xl font-bold mb-4">Regístrate</h2> | |
| <p> | |
| Aquí puedes poner el formulario de registro o un enlace a un formulario externo. | |
| </p> | |
| </section> |
Esta seccion no existe en la maqueta
Comment on lines
+77
to
+92
| <!-- Sede --> | ||
| <section id="sede" class="max-w-4xl mx-auto py-16 px-4"> | ||
| <h2 class="text-3xl font-bold mb-4">Sede</h2> | ||
| <p> | ||
| Información sobre el lugar donde se realizará el evento, dirección, cómo llegar, etc. | ||
| </p> | ||
| </section> | ||
|
|
||
| <!-- Highlights --> | ||
| <section id="highlights" class="max-w-4xl mx-auto py-16 px-4"> | ||
| <h2 class="text-3xl font-bold mb-4">Highlights</h2> | ||
| <p> | ||
| Resalta los puntos más importantes del evento, premios, invitados especiales, actividades, | ||
| etc. | ||
| </p> | ||
| </section> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- Sede --> | |
| <section id="sede" class="max-w-4xl mx-auto py-16 px-4"> | |
| <h2 class="text-3xl font-bold mb-4">Sede</h2> | |
| <p> | |
| Información sobre el lugar donde se realizará el evento, dirección, cómo llegar, etc. | |
| </p> | |
| </section> | |
| <!-- Highlights --> | |
| <section id="highlights" class="max-w-4xl mx-auto py-16 px-4"> | |
| <h2 class="text-3xl font-bold mb-4">Highlights</h2> | |
| <p> | |
| Resalta los puntos más importantes del evento, premios, invitados especiales, actividades, | |
| etc. | |
| </p> | |
| </section> |
Esta seccion no existe en la maqueta
EGAMAGZ
suggested changes
Jun 11, 2025
Member
EGAMAGZ
left a comment
EGAMAGZ
left a comment
There was a problem hiding this comment.
Al llamar las imagenes no lo hagas con / al inicio debido a que cargara la imagen desde raiz en vez de manera relativa
Junto a eso, aunque no tengas las imagenes, puedes usar algunos temporales 😅
| <!-- Header --> | ||
| <header class="w-full px-6 py-4 flex justify-between items-center border-b border-gray-300"> | ||
| <div class="text-lg font-semibold"> | ||
| <img src="/notion-logo.svg" alt="Notion logo" class="w-6 inline-block mr-2" /> |
Member
There was a problem hiding this comment.
Suggested change
| <img src="/notion-logo.svg" alt="Notion logo" class="w-6 inline-block mr-2" /> | |
| <img src="notion-logo.svg" alt="Notion logo" class="w-6 inline-block mr-2" /> |
| </p> | ||
| </div> | ||
| <img | ||
| src="/tu-imagen.jpg" |
Member
There was a problem hiding this comment.
Suggested change
| src="/tu-imagen.jpg" | |
| src="tu-imagen.jpg" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se hace la generación de header de bienvenida.