Skip to content

Remove combine lists #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eloch216 merged 2 commits into from
Mar 11, 2026
Merged

Remove combine lists #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c9eae
Use `modifyList`
eloch216 Sep 5, 2025
eedc565
Update links
eloch216 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ VignetteBuilder: knitr
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
URL: https://github.com/BioCro/BioCroValidation, https://biocro.github.io/BioCroValidation/
URL: https://github.com/BioCro/BioCroValidation, https://biocro.org/BioCroValidation/
Config/testthat/edition: 3
9 changes: 0 additions & 9 deletions R/combine_lists.R
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions R/objective_function_helpers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ get_model_runner <- function(
# Build the runner
tryCatch({
partial_func <- BioCro::partial_run_biocro(
combine_lists(
utils::modifyList(
base_model_definition[['initial_values']],
ddp[['initial_values']]
c(list(), ddp[['initial_values']])
),
combine_lists(
utils::modifyList(
base_model_definition[['parameters']],
ddp[['parameters']]
c(list(), ddp[['parameters']])
),
ddp[['drivers']],
base_model_definition[['direct_modules']],
Expand Down
8 changes: 4 additions & 4 deletions R/objective_function_input_checks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,13 @@ check_data_driver_pairs <- function(base_model_definition, data_driver_pairs, ve
# base model definition
valid_definitions <- sapply(data_driver_pairs, function(ddp) {
BioCro::validate_dynamical_system_inputs(
combine_lists(
utils::modifyList(
base_model_definition[['initial_values']],
ddp[['initial_values']]
c(list(), ddp[['initial_values']])
),
combine_lists(
utils::modifyList(
base_model_definition[['parameters']],
ddp[['parameters']]
c(list(), ddp[['parameters']])
),
ddp[['drivers']],
base_model_definition[['direct_modules']],
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ from within R by typing `install.packages('remotes')`.
### Usage

The best way to learn about using `BioCroValidation` is to visit the
[BioCroValidation website](https://biocro.github.io/BioCroValidation/index.html)
[BioCroValidation website](https://biocro.org/BioCroValidation/index.html)
and click the "Get Started" link in the top menu bar. The website includes
documentation for all the functions and data sets included in the package, as
well as articles that describe its general features and several important use
Expand Down
Loading