Embedders widget - field for a custom server URL#114
Open
PrimozGodec wants to merge 1 commit intobiolab:masterfrom
Open
Embedders widget - field for a custom server URL#114PrimozGodec wants to merge 1 commit intobiolab:masterfrom
PrimozGodec wants to merge 1 commit intobiolab:masterfrom
Conversation
PrimozGodec
force-pushed
the
embedders-server
branch
2 times, most recently
from
72c3335 to
255341b
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 79.9% 76.18% -3.73%
==========================================
Files 7 5 -2
Lines 622 529 -93
Branches 95 84 -11
==========================================
- Hits 497 403 -94
- Misses 97 98 +1
Partials 28 28 |
PrimozGodec
changed the title
lanzagar
reviewed
Sep 21, 2018
| EMBEDDERS_INFO[current_embedder]['description'] | ||
| ) | ||
|
|
||
| advanced_box = widgetBox(self.controlArea, 'Advanced settings') |
Collaborator
There was a problem hiding this comment.
Advanced server settings
or maybe just
Custom server
|
|
||
| advanced_box = widgetBox(self.controlArea, 'Advanced settings') | ||
| self.use_custom_server_cb = checkBox( | ||
| advanced_box, self, 'custom_server', "User custom server", |
| advanced_box, self, 'custom_server', "User custom server", | ||
| callback=self.changed_server_url) | ||
| self.server_url_box = lineEdit( | ||
| advanced_box, self, 'server_url', label="Server URL: ", |
Collaborator
There was a problem hiding this comment.
I think this could be disabled when the above checkbox is not checked.
|
we also need "allow insecure" option, eg. like in curl -k or --insecure (Allow connections to SSL sites without checking certs (H)). We need this if there are self signed certificates installed on the imageanalytics server. |
PrimozGodec
force-pushed
the
embedders-server
branch
from
255341b to
204b651
Compare
Collaborator
Author
Collaborator
Author
|
@matjazp it seems that hyper library does not support "allow insecure" option https://hyper.readthedocs.io/en/latest/advanced.html#ssl-tls-certificate-verification. With @acopar we discussed to just use HTTP instead of HTTPS those cases |
PrimozGodec
force-pushed
the
embedders-server
branch
from
204b651 to
7bf30c6
Compare
|
Very useful!! |
PrimozGodec
force-pushed
the
embedders-server
branch
from
3305200 to
fd86858
Compare
PrimozGodec
force-pushed
the
embedders-server
branch
from
fd86858 to
734fe7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No possibility to set custom server url.
Description of changes
Adding a field and functionality for a custom URL set.
Includes