Reset max stress level metric to minimum #216
Open
vmzhivetyev wants to merge 1 commit intobird-sanctuary:developfrom
Open
Reset max stress level metric to minimum #216vmzhivetyev wants to merge 1 commit intobird-sanctuary:developfrom
vmzhivetyev wants to merge 1 commit intobird-sanctuary:developfrom
Conversation
|
Build artifacts:
|
stylesuxx
requested changes
Sep 12, 2024
Contributor
There was a problem hiding this comment.
Thank you for the comprehensive PR, makes sense in regards to making the behavior consistent.
I think it'd be important to adjust the EDT specs accordingly, since it's not specified in which timeframe context this status frame value is to be seen.
Ping @AlkaMotors - how do you handle the max stress level in the EDT status frame in AM32 - AFAIK you have that implemented too, no?
e99d053 to
554d016
Compare
|
Build artifacts:
|
stylesuxx
approved these changes
Sep 13, 2024
hyp0dermik-code
added a commit
to hyp0dermik-code/extended-dshot-telemetry
that referenced
this pull request
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
Demag_Detected_Metric_Maxcurrently stores the maximum value observed since the ESC was armed. This results in the metric becoming static after reaching its peak, never decreasing until the ESC is disarmed.Proposed Change
Reset the
Demag_Detected_Metric_Maxmetric each time a STATUS telemetry packet is sent. So that the value in a STATUS telemetry packet would represent the Max stress level in the last second (according to current scheduler implementation).Rationale
Tests
This is what 40 seconds of blackbox log look like if recorded with this change.
