Skip to content

Add readers and writers for remaining VTL model classes #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 3, 2025
Merged

Add readers and writers for remaining VTL model classes #325

merged 18 commits into from
Jun 3, 2025

Conversation

javihern98
Copy link
Contributor

@javihern98 javihern98 commented May 31, 2025 •
edited
Loading

Closes #323

Summary of changes

  • Implemented readers and writers on SDMX-ML 2.1 for:
    • VtlDataflowMapping with FromVtlMapping and ToVtlMapping
    • VtlCodelistMapping
    • VtlConceptMapping
    • CustomTypeScheme
    • CustomType
    • NamePersonalisationScheme
    • NamePersonalisation
  • Fixed references handling on TransformationScheme if the object references a VtlMappingScheme, CustomTypeScheme or NamePersonalisationScheme
  • Fixed writing of isPartial for VTL model objects
  • Normalize references classes in all VTL model objects

javihern98 added 18 commits May 29, 2025 16:53
@javihern98
Added reference from TransformationScheme to VTLMappingScheme on stru…
aaffe5d 
…ctures reader

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added as_list parameter as False for VTLMappingScheme.
ede668b 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Changed VTL model to make it uniform with VTL object/Reference
58badd6 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Add items attribute to CustomTypeScheme and NamePersonalisationScheme…
74d5454 
… with its Item class

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added missing Union typing
92d5bdf 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added support for references to CustomType and NamePersonalisation on…
5eb81e5 
… TransformationScheme

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added support on reader SDMX-ML for VtlCodelistMapping and VtlConcept…
c04f814 
…Mapping

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added support for NamePersonalisationScheme and CustomTypeScheme objects
1169cf6 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Refactored format_vtl to remove complexity
34151c5 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Ruff and mypy changes for reader and model.
90cd56b 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Fixed key on OperationDefinition
ac1b448 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added files with complete tests for the new objects. Ensure ordering …
473e7d8 
…of reading is correct and simplified attribute assignment in structures

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added missing references to VTL objects. Fixed order of writing VtlMa…
022a032 
…ppings

Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Finished writing of VTLMappings
e1fdb06 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added writing of CustomTypeScheme and NamePersonalisationScheme
a4614fe 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Added complete vtl test and mypy changes.
dfdf70e 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Updated xml files with is_partial attribute
e69469b 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98
Changed if to inline
1211152 
Signed-off-by: javier.hernandez <73304358+javihern98@users.noreply.github.com>
@javihern98 javihern98 linked an issue May 31, 2025 that may be closed by this pull request
TransformationScheme and other VTL objects reading #323
Closed
@javihern98 javihern98 requested a review from jfrancma May 31, 2025 14:02
jfrancma
jfrancma previously approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@jfrancma jfrancma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready for BIS review

@jfrancma jfrancma marked this pull request as ready for review June 2, 2025 15:47
@jfrancma jfrancma requested review from sosna, stratosn and jfrancma June 2, 2025 15:47
@javihern98 javihern98 dismissed jfrancma’s stale review June 2, 2025 15:52

Cannot approve until BIS review

sosna
sosna approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@sosna sosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 😊

@sosna sosna added the enhancement Update to an existing feature label Jun 3, 2025
@sosna sosna changed the title Added readers and writers for remaining VTL model classes Add readers and writers for remaining VTL model classes Jun 3, 2025
@javihern98 javihern98 merged commit 596cc89 into develop Jun 3, 2025
15 checks passed
@javihern98 javihern98 deleted the cr-323 branch June 3, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosna sosna sosna approved these changes

@stratosn stratosn Awaiting requested review from stratosn

@jfrancma jfrancma Awaiting requested review from jfrancma

Assignees
No one assigned
Labels
enhancement Update to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TransformationScheme and other VTL objects reading
3 participants
@javihern98 @sosna @jfrancma