-
Notifications
You must be signed in to change notification settings - Fork 342
Cross-Origin Bearer API Authentication #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
korbin
wants to merge
10
commits into
bitaxeorg:master
Choose a base branch
from
korbin:cross-origin-api-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a4d4124
add mDNS hostname advertisement
korbin 702471f
temp: try adding mdns dependency from component manager in ci
korbin 2e6e032
add bearer token authentication for cross-origin requests, add token …
korbin 45cb2b3
dont auth check preflight requests
korbin ae224ce
respond to all OPTIONS requests
korbin 90afb54
fix swarm scan, improve swarm ui, improve swarm device deduplication/…
korbin 110a57d
switch swarm scan to use mDNS service discovery
korbin 6e675eb
dont send X-Requested-With without an apiSecret to keep backwards com…
korbin 252ca5d
fix swarm edit form api calls
korbin b781882
add *this* device to swarm when auto-scanning
korbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,48 +2,35 @@ name: Unit Test | |
| on: [push, pull_request] | ||
|
|
||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| build: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these changes on the tests be in a separate PR? |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'recursive' | ||
|
|
||
| - name: esp-idf build | ||
| uses: espressif/esp-idf-ci-action@v1 | ||
| with: | ||
| esp_idf_version: v5.4.2 | ||
| target: esp32s3 | ||
| command: GITHUB_ACTIONS="true" idf.py build | ||
| path: 'test-ci' | ||
|
|
||
| - name: Run tests | ||
| uses: bitaxeorg/esp32-qemu-test-action@main | ||
| with: | ||
| path: 'test-ci' | ||
|
|
||
| - name: Upload event file | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: event-file | ||
| path: ${{ github.event_path }} | ||
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results | ||
| path: report.xml | ||
|
|
||
| - name: Check for test failures | ||
| if: always() | ||
| run: | | ||
| FAILURES=$(grep -oP 'failures="\K[0-9]+' report.xml || echo 0) | ||
| if [ "$FAILURES" -gt 0 ]; then | ||
| echo "::error ::Detected $FAILURES test failures." | ||
| exit 1 | ||
| fi | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'recursive' | ||
| - name: esp-idf build | ||
| uses: espressif/esp-idf-ci-action@v1 | ||
| with: | ||
| esp_idf_version: v5.4.2 | ||
| target: esp32s3 | ||
| command: | | ||
| GITHUB_ACTIONS="true" idf.py add-dependency "espressif/mdns^1.8.2" | ||
| GITHUB_ACTIONS="true" idf.py build | ||
| path: 'test-ci' | ||
| - name: Run tests and show result | ||
| uses: bitaxeorg/esp32-qemu-test-action@main | ||
| with: | ||
| path: 'test-ci' | ||
| - name: Inspect log | ||
| run: cat report.xml | ||
| - name: Publish Unit Test Results | ||
| uses: EnricoMi/publish-unit-test-result-action@v1 | ||
| if: always() | ||
| with: | ||
| files: report.xml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,4 +13,5 @@ REQUIRES | |
| "esp_wifi" | ||
| "esp_event" | ||
| "stratum" | ||
| "mdns" | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed if it's already added in the root
CMakeLists.txt?