Fix: Ensure that isUsingFallbackStratum is a number#1332
Merged
WantClue merged 2 commits intobitaxeorg:masterfrom Dec 17, 2025
Merged
Fix: Ensure that isUsingFallbackStratum is a number#1332WantClue merged 2 commits intobitaxeorg:masterfrom
WantClue merged 2 commits intobitaxeorg:masterfrom
Conversation
Contributor
|
might be superseded by the v2 api refactor, itll be a proper boolean there (along with the others, like |
Collaborator
|
please resolve conflicts |
Collaborator
Author
|
@WantClue done |
WantClue
approved these changes
Dec 14, 2025
0xf0xx0
approved these changes
Dec 15, 2025
Collaborator
It would make sense to make it a number there as well, we're slowly moving towards more than 2 pools. F.e. #1236 adds code to have numbered properties in NVS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
isUsingFallbackStratumis a number, not a boolean, we have to convert it project wide to a number so that it always works as a number, not a boolean.