Skip to content

Fix: Ensure that isUsingFallbackStratum is a number#1332

Merged
WantClue merged 2 commits intobitaxeorg:masterfrom
duckaxe:bugfix/is-fallback-pool-number
Dec 17, 2025
Merged

Fix: Ensure that isUsingFallbackStratum is a number#1332
WantClue merged 2 commits intobitaxeorg:masterfrom
duckaxe:bugfix/is-fallback-pool-number

Conversation

@duckaxe
Copy link
Collaborator

@duckaxe duckaxe commented Nov 6, 2025

As isUsingFallbackStratum is a number, not a boolean, we have to convert it project wide to a number so that it always works as a number, not a boolean.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Test Results

23 tests  ±0   23 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f44b57e. ± Comparison against base commit 50bebdc.

♻️ This comment has been updated with latest results.

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Nov 6, 2025

might be superseded by the v2 api refactor, itll be a proper boolean there (along with the others, like power_fault and overheatMode)

@WantClue
Copy link
Collaborator

please resolve conflicts

@WantClue WantClue added this to the 2.13.0 milestone Dec 11, 2025
@WantClue WantClue added the cleanup Code cleanup label Dec 11, 2025
@duckaxe
Copy link
Collaborator Author

duckaxe commented Dec 12, 2025

@WantClue done

@mutatrum
Copy link
Collaborator

might be superseded by the v2 api refactor, itll be a proper boolean there (along with the others, like power_fault and overheatMode)

It would make sense to make it a number there as well, we're slowly moving towards more than 2 pools. F.e. #1236 adds code to have numbered properties in NVS.

@WantClue WantClue merged commit 00f7755 into bitaxeorg:master Dec 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants