Merged
Conversation
Contributor
WantClue
reviewed
Dec 20, 2025
Collaborator
Author
Apparently the PID max output is a soft limit and it can overshoot, reproduced it by setting the temp to 35C. Added clamping of the PID output. |
WantClue
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a part of #1217 where only the fan controller is extracted. It increased the PID controller frequency from 1.8 seconds to 100ms, which results in a much smoother fan curve. Especially on older devices that uses the EMC2101 internal temp with a 1° C resolution, it's a much more restful soundscape.
I also decreased the PID tuning values quite a bit, but this needs further testing. Maybe the PID parameters need to be exposed under an advanced tab, so people can tune the controller themselves.