Handle client.show_message stratum message#1565
Open
mutatrum wants to merge 1 commit intobitaxeorg:masterfrom
Open
Handle client.show_message stratum message#1565mutatrum wants to merge 1 commit intobitaxeorg:masterfrom
client.show_message stratum message#1565mutatrum wants to merge 1 commit intobitaxeorg:masterfrom
Conversation
0xf0xx0
suggested changes
Feb 20, 2026
Contributor
0xf0xx0
left a comment
0xf0xx0
left a comment
There was a problem hiding this comment.
other than this nit, acked
will test in a bit
| cJSON * params = cJSON_GetObjectItem(json, "params"); | ||
| if (params && cJSON_IsArray(params) && cJSON_GetArraySize(params) > 0) { | ||
| cJSON * msg_item = cJSON_GetArrayItem(params, 0); | ||
| if (msg_item && cJSON_IsString(msg_item)) { |
Contributor
There was a problem hiding this comment.
nit: capping the pool message length to 256 should be done, just printing whatever comes from the pool feels iffy to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the logs of #1558