Support Slip-132 variants #52
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SLIP-132 extended public key support (zpub, ypub, vpub, upub)
Hey @landabaso, I know this might sound crazy, but I keep coming across applications that are constructing descriptors with slip-132 variants even though the concept of the descriptor itself renders this a redundant expression of intent...
Here is a solution to transmute encountered variants to the standard
x|tversions thatbip32expects.Of course I could pre-transform descriptors prior to passing them to this library, but I wanted to see what you thought of this idea.
Changes
re.tsto accept zpub/ypub/vpub/upub prefixes (and their uppercase multisig variants)convertToStandardXpub()inkeyExpressions.tsthat converts SLIP-132 keys to xpub/tpub by swapping version bytes before passing to bip32