Closed
Conversation
91e1507 to
1f65bae
Compare
1f65bae to
5971eba
Compare
5971eba to
3395e9e
Compare
2a166f0 to
123d468
Compare
123d468 to
0e555a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR splits out the pyscrollgroup part from #62 and adds unittests. Key changes:
@dataclasscalledSpriteMetato organize sprite drawing metadata more cleanlydraw()withSpriteMetaobjects for readability and extensibilitySpriteMetalist back to tuples before passing to the renderer, keeping compatibility intactgetattr()forblendmodeto safely handle sprites without it, avoiding exceptions