Cleanup legacy build files and add Makefile for tooling#71
Open
JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Open
Cleanup legacy build files and add Makefile for tooling#71JaskRendix wants to merge 1 commit intobitcraft:masterfrom
JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR removes legacy
setup.pyandsetup.cfgfiles, relying solely onpyproject.tomlfor build and packaging metadata. AMakefileis added to streamline developer workflows with common targets likebuild,publish,install, andtest.Fixed package discovery in
pyproject.tomlfor editable installs: updated[tool.setuptools.packages.find]section:previously,
include = ["pyscroll*"]caused setuptools to misidentify the package duringpip install -e ., leading toModuleNotFoundError, the new configuration ensurespyscrollis reliably discovered and included in builds and editable installs. Now editable install works as expected,import pyscrollresolves correctly across the project