Open
Conversation
|
Would be nice to see this merged... |
Member
|
Hey @kabrio —thanks for your pull request, I finally got back to work on p5.gui. |
Member
Thanks for your contribution, and sorry for the long delay! |
Catz1301
reviewed
Oct 31, 2020
Catz1301
left a comment
There was a problem hiding this comment.
Extremely annoying to check the differences between the files. It's generally a good idea to only change what needs to be changed, and do not convert line endings before committing (unless GitHub automatically handles line endings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple wrapper around quicksettings to be able to add buttons by calling addButton(title, function).
Also wrapped setRangeValue function from quicksettings to enable scripted value changes of sliders.
See button-setRangeValue example for demonstration.