Add missing tests of BitParams (#11852)

[msynk]

closes #11852

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for parameter cascading functionality, including validation of null/empty handling, child content rendering, and dynamic parameter updates during rerenders.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Adds comprehensive unit tests for the BitParams component, including four new test files: a test class with eight MSTest unit tests, two parameter test helper classes (FakeParamsA and FakeParamsB), and a test utility Blazor component (ParamsConsumer) that consumes cascading parameters.

Changes

Cohort / File(s)	Summary
BitParams unit tests src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/BitParamsTests.cs	Adds BitParamsTests class with 8 MSTest unit tests covering parameter cascading, null/empty parameter handling, child content rendering, unknown parameter handling, and dynamic parameter updates.
Test parameter helpers src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/FakeParamsA.cs, FakeParamsB.cs	Adds two sealed test helper classes implementing IBitComponentParams. FakeParamsA exposes Name ("A") and Value (1); FakeParamsB exposes Name ("B") and Text ("Hello").
Test utility component src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/ParamsConsumer.cs	Adds ParamsConsumer sealed Blazor component that consumes two cascading parameters (FakeParamsA and FakeParamsB) and renders their combined values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• All test files follow straightforward patterns with minimal logic
• Test helper classes are simple property definitions
• Main test class structure is consistent across all test methods
• No complex assertions or intricate setup logic

Poem

A rabbit hops through tests so bright,
Cascading params checked just right,
With FakeParams A and B in sight,
BitParams dances through the night! 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: adding missing tests for the BitParams component.
Linked Issues check	✅ Passed	The pull request adds comprehensive unit tests for BitParams covering cascading parameters, null/empty handling, child content rendering, and dynamic updates, fulfilling the objective to add unit tests for the component.
Out of Scope Changes check	✅ Passed	All changes are scoped to adding BitParams unit tests and their supporting test helper classes, with no unrelated modifications detected.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/BitParamsTests.cs (2)

35-69: Good coverage of provider values; be aware of internal coupling

The two tests

• ShouldProvideValuesWithNamesAndFixedFlag
• ShouldSkipNullParameters

thoroughly verify that BitParams:

• passes the original param instances into BitCascadingValueProvider,
• preserves the Name,
• marks them as fixed, and
• filters out null entries.

The only trade‑off is that they directly depend on the BitCascadingValueProvider type and its Values shape, so refactoring the internal plumbing (while preserving observable behavior) could break these tests. That’s reasonable if you want to lock in the current implementation, but if you anticipate internal changes, consider adding a more black‑box test variant that asserts behavior only via rendered output.

---

103-137: Unknown-parameter handling and rerender behavior look correct; minor async refinement possible

The last two tests:

• ShouldIgnoreUnknownParametersAndNotThrow correctly verifies that SetParametersAsync ignores an "Unknown" parameter while still wiring up Parameters.
• ShouldUpdateParametersOnRerender validates that changing the parameters from FakeParamsA to FakeParamsB results in the expected "-Hello" output from ParamsConsumer, confirming that cascading values update across renders.

The synchronous GetAwaiter().GetResult() on InvokeAsync is acceptable in this MSTest/bUnit context, but if you ever move to async test methods you could simplify that test to await component.Instance.SetParametersAsync(parameters) instead.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 2c4972a and e119a55.

📒 Files selected for processing (4)

• src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/BitParamsTests.cs (1 hunks)
• src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/FakeParamsA.cs (1 hunks)
• src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/FakeParamsB.cs (1 hunks)
• src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/ParamsConsumer.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build Bit.BlazorUI

🔇 Additional comments (5)

src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/FakeParamsA.cs (1)

3-7: Simple, stable test stub looks good

FakeParamsA is a minimal, immutable implementation tailored for the BitParams tests and reads clearly (fixed Name and Value). No changes needed here.

src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/ParamsConsumer.cs (1)

6-15: Cascading parameter consumer is correct and aligns with tests

ParamsConsumer correctly binds to the named cascading parameters "A" and "B" and renders the expected "value-text" pattern (including the "-Hello" case when A is absent). The use of null-conditional accessors and a single sequence in BuildRenderTree is appropriate here.

src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/FakeParamsB.cs (1)

3-7: Symmetric, deterministic test parameter implementation

FakeParamsB mirrors FakeParamsA in structure and provides fixed, human-readable values for the tests. It’s a good, simple fixture class for exercising BitParams behavior.

src/BlazorUI/Bit.BlazorUI.Tests/Utils/Params/BitParamsTests.cs (2)

12-32: End‑to‑end cascading test is clear and robust

ShouldCascadeParametersToChildren nicely validates the full pipeline: BitParams → cascading values → ParamsConsumer output "1-Hello". The use of real component composition instead of inspecting internals gives a solid behavioral test.

---

71-101: Rendering behavior with null/empty parameters is well covered

The trio of tests

• ShouldRenderChildContentWhenParametersNull
• ShouldRenderChildContentWhenParametersEmpty
• ShouldRenderEmptyWhenNoChildAndNoParameters

provide good coverage of the main edge cases for BitParams rendering. They make the intended contract very explicit and should catch regressions in how the component handles missing or empty parameter collections.