This repository was archived by the owner on Oct 26, 2021. It is now read-only.
Conversation
Owner
|
Thanks for getting the bitfield strategy specified! I expect we'll talk about this on the call tomorrow. |
osoftware
commented
Dec 12, 2019
|
|
||
| Once the `template` parameter is determined, it needs to be encoded to bytes, and then minimally pushed the same way as `checkbits` in `OP_CHECKMULTISIG`. While the encoding to bytes is straight forward, it is worth emphasizing that certain length-1 byte vectors must be pushed using special opcodes. | ||
|
|
||
| * For `template <= 8`, a length-1 byte array is to be pushed. |
Author
There was a problem hiding this comment.
This needs rephrasing. It's about the number of bits, bitwise length or the position of the highest bit set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding of the
templatethe same way ascheckbitsinOP_CHECKMULTISIG.