Conversation
tothszabi
force-pushed
the
STEP-2142-git-command
branch
from
efab978 to
9f17051
Compare
tothszabi
force-pushed
the
STEP-2142-git-command
branch
from
9f17051 to
b1eaaa8
Compare
benbitrise
approved these changes
Feb 4, 2026
Comment on lines
+117
to
+160
| func (f *factory) SparseCheckoutInit(cone bool) Template { | ||
| args := []string{"sparse-checkout", "init"} | ||
| if cone { | ||
| args = append(args, "--cone") | ||
| } | ||
| return f.template(args...) | ||
| } | ||
|
|
||
| // Config ... | ||
| func (f *factory) Config(key string, value string, opts ...string) Template { | ||
| args := []string{"config", key, value} | ||
| args = append(args, opts...) | ||
| return f.template(args...) | ||
| } | ||
|
|
||
| // UpdateRef ... | ||
| func (f *factory) UpdateRef(opts ...string) Template { | ||
| args := append([]string{"update-ref"}, opts...) | ||
| return f.template(args...) | ||
| } | ||
|
|
||
| // RevParse ... | ||
| func (f *factory) RevParse(arg string) Template { | ||
| return f.template("rev-parse", arg) | ||
| } | ||
|
|
||
| // RevList ... | ||
| func (f *factory) RevList(commit string, opts ...string) Template { | ||
| args := []string{"rev-list", commit} | ||
| args = append(args, opts...) | ||
| return f.template(args...) | ||
| } | ||
|
|
||
| // Log ... | ||
| func (f *factory) Log(format string, opts ...string) Template { | ||
| args := []string{"log", "-1", "--format=" + format} | ||
| args = append(args, opts...) | ||
| return f.template(args...) | ||
| } | ||
|
|
||
| // SubmoduleForeach ... | ||
| func (f *factory) SubmoduleForeach(action Template) Template { | ||
| args := []string{"submodule", "foreach"} | ||
| if t, ok := action.(*template); ok { |
There was a problem hiding this comment.
So if this type assertion fails then the function just runs git submodule foreach with no args?
There was a problem hiding this comment.
Approving so you can merge. Up to you if you want to follow on with a PR to prevent this in the future. Or maybe we can be confident that it'll always be type template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New git commands.