Move export to v2/codesigngroup #310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| package codesigngroup | ||
|
|
||
| import ( | ||
| "sort" | ||
|
|
||
| "github.com/bitrise-io/go-xcode/certificateutil" | ||
| "github.com/bitrise-io/go-xcode/profileutil" | ||
| "github.com/ryanuber/go-glob" | ||
| ) | ||
|
|
||
| // CodeSignGroup ... | ||
| type CodeSignGroup interface { | ||
| Certificate() certificateutil.CertificateInfoModel | ||
| InstallerCertificate() *certificateutil.CertificateInfoModel | ||
| BundleIDProfileMap() map[string]profileutil.ProvisioningProfileInfoModel | ||
| } | ||
|
|
||
| // SelectableCodeSignGroup ... | ||
| type SelectableCodeSignGroup struct { | ||
| Certificate certificateutil.CertificateInfoModel | ||
| BundleIDProfilesMap map[string][]profileutil.ProvisioningProfileInfoModel | ||
| } | ||
|
|
||
| func containsCertificate(installedCertificates []certificateutil.CertificateInfoModel, certificate certificateutil.CertificateInfoModel) bool { | ||
|
Contributor
There was a problem hiding this comment. NIT: I suggest using a bit more generic param names, maybe utilising |
||
| for _, cert := range installedCertificates { | ||
| if cert.Serial == certificate.Serial { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // BuildFilterableList ... | ||
| func BuildFilterableList(installedCertificates []certificateutil.CertificateInfoModel, profiles []profileutil.ProvisioningProfileInfoModel, bundleIDs []string) []SelectableCodeSignGroup { | ||
| groups := []SelectableCodeSignGroup{} | ||
|
|
||
| serialToProfiles := map[string][]profileutil.ProvisioningProfileInfoModel{} | ||
| serialToCertificate := map[string]certificateutil.CertificateInfoModel{} | ||
| for _, profile := range profiles { | ||
| for _, certificate := range profile.DeveloperCertificates { | ||
| if !containsCertificate(installedCertificates, certificate) { | ||
| continue | ||
| } | ||
|
|
||
| certificateProfiles, ok := serialToProfiles[certificate.Serial] | ||
| if !ok { | ||
| certificateProfiles = []profileutil.ProvisioningProfileInfoModel{} | ||
| } | ||
| certificateProfiles = append(certificateProfiles, profile) | ||
| serialToProfiles[certificate.Serial] = certificateProfiles | ||
| serialToCertificate[certificate.Serial] = certificate | ||
| } | ||
| } | ||
|
|
||
| for serial, profiles := range serialToProfiles { | ||
| certificate := serialToCertificate[serial] | ||
|
|
||
| bundleIDToProfiles := map[string][]profileutil.ProvisioningProfileInfoModel{} | ||
| for _, bundleID := range bundleIDs { | ||
|
|
||
| matchingProfiles := []profileutil.ProvisioningProfileInfoModel{} | ||
| for _, profile := range profiles { | ||
| if !glob.Glob(profile.BundleID, bundleID) { | ||
| continue | ||
| } | ||
|
|
||
| matchingProfiles = append(matchingProfiles, profile) | ||
| } | ||
|
|
||
| if len(matchingProfiles) > 0 { | ||
| sort.Sort(ByBundleIDLength(matchingProfiles)) | ||
|
Contributor
There was a problem hiding this comment. NIT: this slice sort also could be simpler (and without the additional sort helper structure The slices.SortFunc comparator returns:
Since we want to sort by descending length (longest first), we return len(b.BundleID) - len(a.BundleID). |
||
| bundleIDToProfiles[bundleID] = matchingProfiles | ||
| } | ||
| } | ||
|
|
||
| if len(bundleIDToProfiles) == len(bundleIDs) { | ||
| group := SelectableCodeSignGroup{ | ||
| Certificate: certificate, | ||
| BundleIDProfilesMap: bundleIDToProfiles, | ||
| } | ||
| groups = append(groups, group) | ||
| } | ||
| } | ||
|
|
||
| return groups | ||
| } | ||
|
|
||
| // ByBundleIDLength ... | ||
| type ByBundleIDLength []profileutil.ProvisioningProfileInfoModel | ||
|
|
||
| // Len .. | ||
| func (s ByBundleIDLength) Len() int { | ||
| return len(s) | ||
| } | ||
|
|
||
| // Swap ... | ||
| func (s ByBundleIDLength) Swap(i, j int) { | ||
| s[i], s[j] = s[j], s[i] | ||
| } | ||
|
|
||
| // Less ... | ||
| func (s ByBundleIDLength) Less(i, j int) bool { | ||
| return len(s[i].BundleID) > len(s[j].BundleID) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this interface used?