[Hardfork] Added disable_modify_max_supply flag#1612
Closed
xeroc wants to merge 2 commits intobitshares:developfrom
Closed
[Hardfork] Added disable_modify_max_supply flag#1612xeroc wants to merge 2 commits intobitshares:developfrom
xeroc wants to merge 2 commits intobitshares:developfrom
Conversation
Member
Author
|
BSIP here: The only thing (as can be seen from the BSIP) that I am unaware about is: |
Contributor
|
Can we close #1375 then? |
Member
Author
Oh my ... I am sorry, totally forgot about the open pull request. Will move the improvements to the other open pull request where discussion already took place. closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request collides with #1611 as it uses the same value for the flag.
This feature introduces a flag that prevents issues from changing the max_supply of an asset.
Obviously, for this flag to make sense, the issuer would need to also disable the corresponding permission.
A BSIP for this PR will follow shortly
(paging @Dimfred)