Include a restart parameter #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s intended to happen on `:DOWN` message.
Basically the version 3.4.0 this change is based on ignores handoffs when the reason isn’t :noconnection (node down event); but this is bad when you do need a handoff during “graceful shutdowns”.
The `restart` parameter will assume the same values as those passed to `Supervisor` child spec: if `:permanent` then a handoff will occur always, if `:transient` only if the terminate reason is other than `:normal | :shutdown | {:shutdown, term}`, and if `:temporary` then it is never restarted, only when the node is down (that's the normal old behavior which is assumed by default).
Author
|
Indicating that the process should have a lifetime that surpasses the natural logic of a regular |
Author
|
This PR also solves #11 as the indicated solution of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
Swarm.Trackercan figure out what is intended to happen on:DOWNmessage.Basically the version 3.4.0 this change is based on ignores handoffs when the reason isn’t
:noconnection(node down event); but this is bad when you do need a handoff during “graceful shutdowns”.The
restartparameter will assume the same values as those passed toSupervisorchild spec: if:permanentthen a handoff will occur always, if:transientonly if the terminate reason is other than:normal | :shutdown | {:shutdown, term}, and if:temporarythen it is never restarted, only when the node is down (that's the normal old behaviour which is assumed by default).That's the same idea described on Supervisor / Restart values but applied to a cluster.