Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29911

📔 Objective

Matching iOS with PR 2197, this unifies the Crowdin Pull and Google Privileged Browser Sync cron jobs to both run over the weekend, to take advantage of off-hours for the runners. More specifically, this updates them to run at midnight on Sundays (UTC).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner December 17, 2025 20:44
@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Claude finished @KatherineInCode's task in 1m 34s —— View job


Code Review Complete ✅

  • Analyzing PR changes
  • Reviewing cron schedule updates
  • Posting review feedback

Overall Assessment: APPROVE

Both workflow files have been properly updated to run at midnight on Sundays (UTC):

  • cron-sync-google-priviledged-browsers.yml: Changed from Monday to Sunday
  • crowdin-pull.yml: Changed from Friday to Sunday

The cron syntax '0 0 * * 0' is correct for "midnight on Sundays UTC" and both files are now consistent with each other and with the stated objective.

No issues found. The PR is ready to merge.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.51%. Comparing base (7c929c3) to head (f393e5c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6280      +/-   ##
==========================================
- Coverage   85.53%   85.51%   -0.03%     
==========================================
  Files         761      762       +1     
  Lines       54522    54530       +8     
  Branches     7833     7833              
==========================================
- Hits        46636    46630       -6     
- Misses       5169     5183      +14     
  Partials     2717     2717              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Overall Assessment: APPROVE

Reviewed cron schedule updates for two GitHub workflow files - both correctly changed to run at midnight on Sundays (UTC) using cron syntax '0 0 * * 0'.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0d80af5a-5f85-4175-9300-158dfc429176

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit c16da50 Dec 18, 2025
17 of 18 checks passed
@SaintPatrck SaintPatrck deleted the pm-29911/cron-times branch December 18, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants