Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Sep 12, 2024

🎟️ Tracking

📔 Objective

Linux is now supported via Polkit.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner September 12, 2024 11:00
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 12, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 278a5e1
Status: ✅  Deploy successful!
Preview URL: https://3dfda806.contributing-docs.pages.dev
Branch Preview URL: https://km---linux-biometrics.contributing-docs.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Logo
Checkmarx One – Scan Summary & Details12fdbf15-6df9-473e-afdf-0c82d2fd692a

Great job! No new security vulnerabilities introduced in this pull request

- Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download)
- Mac Apple Store downloaded Mac App
- Windows Desktop Apps via Windows Hello
- Linux Desktop via Polkit
Copy link
Contributor

@djsmith85 djsmith85 Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Tiny nit as it's part of all the supported ones above

Suggested change
- Linux Desktop via Polkit
- Linux Desktop Apps via Polkit

- Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download)
- Mac Apple Store downloaded Mac App
- Windows Desktop Apps via Windows Hello
- Linux Desktop via Polkit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The linter is complaining as it doesn't know the word Polkit

@claude
Copy link

claude bot commented Nov 25, 2025

Claude finished @quexten's task —— View job


PR Review Complete

I've reviewed this PR and the existing reviewer feedback. Here are the findings:

Summary of Changes

This PR updates the biometric unlock documentation to reflect that Linux is now supported via Polkit. The change moves "Linux OS" from the "Not Supported" section and adds "Linux Desktop via Polkit" to the "Supported" section.

Findings

Finding 1: ⚠️ The word "Polkit" is not in the custom dictionary, causing linter failures.

Finding 2: 🎨 The phrasing should match the pattern of other supported platforms for consistency.

Status of Previous Review Comments

  • djsmith85's suggestion to change "(Polkit)" to "via Polkit" appears to have been addressed in line 24
  • The linter issue with "Polkit" not being in the dictionary remains unresolved

Recommendations

  1. Add "Polkit" to custom-words.txt (alphabetically between "pinentry" and "PNSs")
  2. Consider changing "Linux Desktop via Polkit" to "Linux Desktop Apps via Polkit" to match the pattern of "Windows Desktop Apps via Windows Hello"

Documentation Quality

The documentation change is accurate and well-placed. The update correctly reflects the new Linux support and maintains the existing structure of the document.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants