-
Notifications
You must be signed in to change notification settings - Fork 21
Update docs about linux biometrics #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying contributing-docs with
|
| Latest commit: |
278a5e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3dfda806.contributing-docs.pages.dev |
| Branch Preview URL: | https://km---linux-biometrics.contributing-docs.pages.dev |
|
Great job! No new security vulnerabilities introduced in this pull request |
| - Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download) | ||
| - Mac Apple Store downloaded Mac App | ||
| - Windows Desktop Apps via Windows Hello | ||
| - Linux Desktop via Polkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 Tiny nit as it's part of all the supported ones above
| - Linux Desktop via Polkit | |
| - Linux Desktop Apps via Polkit |
| - Side-loaded Windows Desktop App from the [help site](https://bitwarden.com/download) | ||
| - Mac Apple Store downloaded Mac App | ||
| - Windows Desktop Apps via Windows Hello | ||
| - Linux Desktop via Polkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polkit
|
Claude finished @quexten's task —— View job PR Review CompleteI've reviewed this PR and the existing reviewer feedback. Here are the findings: Summary of Changes This PR updates the biometric unlock documentation to reflect that Linux is now supported via Polkit. The change moves "Linux OS" from the "Not Supported" section and adds "Linux Desktop via Polkit" to the "Supported" section. Findings Finding 1: Finding 2: 🎨 The phrasing should match the pattern of other supported platforms for consistency. Status of Previous Review Comments
Recommendations
Documentation Quality The documentation change is accurate and well-placed. The update correctly reflects the new Linux support and maintains the existing structure of the document. |

🎟️ Tracking
📔 Objective
Linux is now supported via Polkit.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes